Skip to content

[BUG][java][restclient] Fix NPE when query param with value null is exploded#23505

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
InditexTech:bugfix/GH-23504-NPE-query-params
Apr 10, 2026
Merged

[BUG][java][restclient] Fix NPE when query param with value null is exploded#23505
wing328 merged 1 commit intoOpenAPITools:masterfrom
InditexTech:bugfix/GH-23504-NPE-query-params

Conversation

@jorgerod
Copy link
Copy Markdown
Contributor

@jorgerod jorgerod commented Apr 9, 2026

Closes #23504

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)


Summary by cubic

Fixes a NullPointerException in the Java restclient generator when exploded query parameters are null. Generated APIs now guard exploded object/array query params with a null check for form and deepObject styles.

  • Bug Fixes
    • In Java/libraries/restclient/api.mustache, wrap exploded param mapping with if (param != null) { ... } when isExplode and the param has fields.
    • Updated sample QueryApi.java to add the same null guards for exploded objects and arrays.
    • Added a test to ensure JavaClientCodegen.RESTCLIENT generates the null check for exploded query params.

Written for commit 8f927df. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@wing328 wing328 merged commit 0c5a529 into OpenAPITools:master Apr 10, 2026
27 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][java][restclient] Fix NPE when query param with value null is exploded

2 participants