Skip to content

[javascript] [typescript] [php] [ruby] Simplify url parameter replacement code#23485

Open
coffeemakr wants to merge 1 commit intoOpenAPITools:masterfrom
coffeemakr:simplify-generated-url-replacement
Open

[javascript] [typescript] [php] [ruby] Simplify url parameter replacement code#23485
coffeemakr wants to merge 1 commit intoOpenAPITools:masterfrom
coffeemakr:simplify-generated-url-replacement

Conversation

@coffeemakr
Copy link
Copy Markdown
Contributor

@coffeemakr coffeemakr commented Apr 8, 2026

Generate url parameter tokens without string concatenation or string templates.

I used 2 regexes:

`\{\$\{"\{\{([a-zA-Z]+)\}\}"\}\}`
'\{' [+.] '\{\{([a-zA-Z]+)\}\}' [+.] '\}'

With the replacement

{{=<< >>=}}'{<<$1>>}'<<={{ }}=>>

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Simplified URL path parameter replacement in generated clients by using literal tokens like '{param}' instead of concatenation or template strings. This makes the code smaller and easier to read with no behavior changes.

  • Refactors
    • Generate path replacements using literal '{param}' tokens via Mustache delimiter swaps, replacing patterns like '{' + '{{baseName}}' + '}' and `{${"{{baseName}}"}}`.
    • Applied across JS/TS (typescript-axios, typescript-fetch, typescript-jquery, typescript-node, typescript-redux-query, Javascript-Closure-Angular, Javascript-Flowtyped), PHP (php, php-nextgen, psr-18), and Ruby templates.
    • Regenerated samples to reflect the new token style.

Written for commit 30b0a16. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 135 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed. We prioritized the most important files first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant