Fix #17754: Convert OpenAPI types to Python types in anyOf/oneOf#23006
Draft
pgoslatara wants to merge 1 commit intoOpenAPITools:masterfrom
Draft
Fix #17754: Convert OpenAPI types to Python types in anyOf/oneOf#23006pgoslatara wants to merge 1 commit intoOpenAPITools:masterfrom
pgoslatara wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
…f/oneOf - Add toPythonType() helper method to convert OpenAPI types (string, array) to Python types (str, List) - Override postProcessModels() to convert anyOf/oneOf types in AbstractPythonCodegen and AbstractPythonPydanticV1Codegen - Add test case to verify anyOf with string and array types generates correct Python types Before: anyOf schemas contained ['array[string]', 'string'] After: anyOf schemas contain ['List[str]', 'str']
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: anyOf schemas contained ['array[string]', 'string']
After: anyOf schemas contain ['List[str]', 'str']
Fixes #17754.
Python technical committee: @cbornet @tomplus @krjakbrjak @fa0311 @multani
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes #17754 by converting anyOf/oneOf OpenAPI types to proper Python types in generated Python clients. Schemas like array[string] now render as List[str], and string as str.
Written for commit c357866. Summary will update on new commits.