Skip to content

[OCaml][Fix] Unreferenced enum + Direct recursive types#23005

Draft
sir4ur0n wants to merge 6 commits intoOpenAPITools:masterfrom
sir4ur0n:fix/ocaml-unreferenced-enum
Draft

[OCaml][Fix] Unreferenced enum + Direct recursive types#23005
sir4ur0n wants to merge 6 commits intoOpenAPITools:masterfrom
sir4ur0n:fix/ocaml-unreferenced-enum

Conversation

@sir4ur0n
Copy link
Contributor

@sir4ur0n sir4ur0n commented Feb 18, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes crashes in the OCaml client generator when enums appear in anyOf/allOf/oneOf, and adds robust support for direct self-recursive models across properties, arrays, and maps. Adds targeted tests and samples, and updates CI to OCaml 5.3.

  • Bug Fixes

    • Recursively collect enums in composed schemas (anyOf/allOf/oneOf), including direct branch enums and nested $ref; prefix composed enum types with Enums.
    • Make enum hashing order-independent with Set, fixing “unreferenced enum” and supporting empty-string enum values.
  • New Features

    • Support direct recursive models by normalizing self-references to t across fields and container items; handle required recursive fields and multiple recursive properties.
    • Add 3.0 test specs and samples for composed-schema enums and recursion; update OCaml generator help text.

Written for commit f3e7e8d. Summary will update on new commits.

Problem: The OCaml client generator threw IllegalArgumentException: Unreferenced enum when encountering enums inside composed schemas
  (anyOf/allOf/oneOf).

Root Causes:
1. The enum collection logic didn't traverse into composed schemas
2. The enum hashing used order-dependent string concatenation, causing lookups to fail when enum values appeared in different orders
3. Enums directly within composed schema branches (not in properties) weren't collected

Solution:

1. Added composed schema support:
  - New `collectEnumSchemasFromComposed()` method handles `anyOf/allOf/oneOf`
  - New `collectEnumSchemasFromList()` method recursively processes composed schema branches
  - Enums directly in composed schemas (not just in properties) are now collected
2. Refactored enum hashing to use Set:
  - Changed from comma-joined strings to `TreeSet<String>` for order-independent, collision-free hashing
  - Handles edge cases like empty string enums `""`
3. Added test case:
  - Tests enums in nested composed schemas
  - Tests enum with empty string value in anyOf
@sir4ur0n sir4ur0n force-pushed the fix/ocaml-unreferenced-enum branch from 42aac2b to 067bd6b Compare February 18, 2026 13:30
@sir4ur0n sir4ur0n changed the title [OCaml][Fix] Unreferenced enum [OCaml][Fix] Unreferenced enum + Direct recursive types Feb 18, 2026
@sir4ur0n sir4ur0n force-pushed the fix/ocaml-unreferenced-enum branch from 834c084 to 47680b2 Compare February 18, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments