Skip to content

fix: don't create files for resources/datasources that don't expose qualifying create/read endpoints#22994

Draft
jasondamour wants to merge 1 commit intoOpenAPITools:masterfrom
jasondamour:terraform-provider-improvements
Draft

fix: don't create files for resources/datasources that don't expose qualifying create/read endpoints#22994
jasondamour wants to merge 1 commit intoOpenAPITools:masterfrom
jasondamour:terraform-provider-improvements

Conversation

@jasondamour
Copy link
Contributor

@jasondamour jasondamour commented Feb 17, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Skip generating Terraform resource and data source files when a tag lacks a create or read endpoint. This avoids broken builds and removes unused model files.

  • Bug Fixes

    • Track qualifying tags and delete non-resource/data-source files in postProcessFile (_resource.go, _data_source.go, _model.go).
    • Only register resources with create and data sources with read via isResource/isDataSource in provider.mustache.
    • Treat read-only fields as computed, not required.
    • Log a warning when the ID field can’t be resolved from the read response.
  • Dependencies

    • Update go.mod template: set module path to github.com/teamlumos/knowledge-server and add indirect deps needed by the framework.

Written for commit 5f87a14. Summary will update on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments