Skip to content

[JAVA][FEIGN] Put back hardcoded HTTP Client but without the performance issue created in 8484. This is fix for 21187 #22905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 2 commits into from
Feb 6, 2026
+36 −0
Merged

[JAVA][FEIGN] Put back hardcoded HTTP Client but without the performance issue created in 8484. This is fix for 21187 #22905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b43d8ee
BUG:21187 put back hardcoded client without the issue created in 8484
Feb 5, 2026
93ef901
BUG:21187 put back hardcoded client without the issue created in 8484
sushma3690 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions modules/openapi-generator/src/main/resources/Java/libraries/feign/ApiClient.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ import feign.jackson.JacksonEncoder;
import feign.gson.GsonDecoder;
import feign.gson.GsonEncoder;
{{/gson}}
{{#feign-okhttp}}
import feign.okhttp.OkHttpClient;
{{/feign-okhttp}}
{{#feign-hc5}}
import feign.hc5.ApacheHttp5Client;
{{/feign-hc5}}
import feign.slf4j.Slf4jLogger;
import {{invokerPackage}}.auth.HttpBasicAuth;
import {{invokerPackage}}.auth.HttpBearerAuth;
Expand Down Expand Up @@ -65,12 +71,24 @@ public class ApiClient {
protected String basePath = "{{{basePath}}}";
protected Map<String, RequestInterceptor> apiAuthorizations;
protected Feign.Builder feignBuilder;
{{#feign-okhttp}}
private static final OkHttpClient OK_HTTP_CLIENT = new OkHttpClient();
{{/feign-okhttp}}
{{#feign-hc5}}
private static final ApacheHttp5Client APACHE_HTTP5_CLIENT = new ApacheHttp5Client();
{{/feign-hc5}}

public ApiClient() {
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
{{#jackson}}
objectMapper = createObjectMapper();
feignBuilder = Feign.builder()
{{#feign-okhttp}}
.client(OK_HTTP_CLIENT)
{{/feign-okhttp}}
{{#feign-hc5}}
.client(APACHE_HTTP5_CLIENT)
{{/feign-hc5}}
.encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
.decoder(new ApiResponseDecoder(objectMapper))
{{#hasOAuthMethods}}
Expand All @@ -81,6 +99,12 @@ public class ApiClient {
{{/jackson}}
{{#gson}}
feignBuilder = Feign.builder()
{{#feign-okhttp}}
.client(OK_HTTP_CLIENT)
{{/feign-okhttp}}
{{#feign-hc5}}
.client(APACHE_HTTP5_CLIENT)
{{/feign-hc5}}
.encoder(new FormEncoder(new GsonEncoder()))
.decoder(new GsonDecoder())
{{#hasOAuthMethods}}
Expand Down
3 changes: 3 additions & 0 deletions samples/client/echo_api/java/feign-gson/src/main/java/org/openapitools/client/ApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import feign.form.FormEncoder;
import feign.gson.GsonDecoder;
import feign.gson.GsonEncoder;
import feign.okhttp.OkHttpClient;
import feign.slf4j.Slf4jLogger;
import org.openapitools.client.auth.HttpBasicAuth;
import org.openapitools.client.auth.HttpBearerAuth;
Expand All @@ -40,10 +41,12 @@ public interface Api {}
protected String basePath = "http://localhost:3000";
protected Map<String, RequestInterceptor> apiAuthorizations;
protected Feign.Builder feignBuilder;
private static final OkHttpClient OK_HTTP_CLIENT = new OkHttpClient();

public ApiClient() {
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
feignBuilder = Feign.builder()
.client(OK_HTTP_CLIENT)
.encoder(new FormEncoder(new GsonEncoder()))
.decoder(new GsonDecoder())
.logger(new Slf4jLogger());
Expand Down
3 changes: 3 additions & 0 deletions samples/client/petstore/java/feign-hc5/src/main/java/org/openapitools/client/ApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import feign.form.FormEncoder;
import feign.jackson.JacksonDecoder;
import feign.jackson.JacksonEncoder;
import feign.hc5.ApacheHttp5Client;
import feign.slf4j.Slf4jLogger;
import org.openapitools.client.auth.HttpBasicAuth;
import org.openapitools.client.auth.HttpBearerAuth;
Expand All @@ -54,11 +55,13 @@ public interface Api {}
protected String basePath = "http://petstore.swagger.io:80/v2";
protected Map<String, RequestInterceptor> apiAuthorizations;
protected Feign.Builder feignBuilder;
private static final ApacheHttp5Client APACHE_HTTP5_CLIENT = new ApacheHttp5Client();

public ApiClient() {
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
objectMapper = createObjectMapper();
feignBuilder = Feign.builder()
.client(APACHE_HTTP5_CLIENT)
.encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
.decoder(new ApiResponseDecoder(objectMapper))
.errorDecoder(new ApiErrorDecoder())
Expand Down
3 changes: 3 additions & 0 deletions ...ient/petstore/java/feign-no-nullable/src/main/java/org/openapitools/client/ApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import feign.form.FormEncoder;
import feign.jackson.JacksonDecoder;
import feign.jackson.JacksonEncoder;
import feign.okhttp.OkHttpClient;
import feign.slf4j.Slf4jLogger;
import org.openapitools.client.auth.HttpBasicAuth;
import org.openapitools.client.auth.HttpBearerAuth;
Expand All @@ -53,11 +54,13 @@ public interface Api {}
protected String basePath = "http://petstore.swagger.io:80/v2";
protected Map<String, RequestInterceptor> apiAuthorizations;
protected Feign.Builder feignBuilder;
private static final OkHttpClient OK_HTTP_CLIENT = new OkHttpClient();

public ApiClient() {
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
objectMapper = createObjectMapper();
feignBuilder = Feign.builder()
.client(OK_HTTP_CLIENT)
.encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
.decoder(new ApiResponseDecoder(objectMapper))
.errorDecoder(new ApiErrorDecoder())
Expand Down
3 changes: 3 additions & 0 deletions samples/client/petstore/java/feign/src/main/java/org/openapitools/client/ApiClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import feign.form.FormEncoder;
import feign.jackson.JacksonDecoder;
import feign.jackson.JacksonEncoder;
import feign.okhttp.OkHttpClient;
import feign.slf4j.Slf4jLogger;
import org.openapitools.client.auth.HttpBasicAuth;
import org.openapitools.client.auth.HttpBearerAuth;
Expand All @@ -54,11 +55,13 @@ public interface Api {}
protected String basePath = "http://petstore.swagger.io:80/v2";
protected Map<String, RequestInterceptor> apiAuthorizations;
protected Feign.Builder feignBuilder;
private static final OkHttpClient OK_HTTP_CLIENT = new OkHttpClient();

public ApiClient() {
apiAuthorizations = new LinkedHashMap<String, RequestInterceptor>();
objectMapper = createObjectMapper();
feignBuilder = Feign.builder()
.client(OK_HTTP_CLIENT)
.encoder(new FormEncoder(new JacksonEncoder(objectMapper)))
.decoder(new ApiResponseDecoder(objectMapper))
.errorDecoder(new ApiErrorDecoder())
Expand Down
Loading