[Kotlin][jvm-spring-webclient] Support accessing basePath & basePathWithoutHost#22876
Open
svenallers wants to merge 3 commits intoOpenAPITools:masterfrom
Open
[Kotlin][jvm-spring-webclient] Support accessing basePath & basePathWithoutHost#22876svenallers wants to merge 3 commits intoOpenAPITools:masterfrom
basePath & basePathWithoutHost#22876svenallers wants to merge 3 commits intoOpenAPITools:masterfrom
Conversation
There was a problem hiding this comment.
1 issue found across 40 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="samples/client/petstore/kotlin-jvm-spring-2-webclient/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt">
<violation number="1" location="samples/client/petstore/kotlin-jvm-spring-2-webclient/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt:82">
P2: createUrlWithBasePath blindly appends basePath even when baseUrl already includes it (BASE_URL already ends with /v2 and basePath defaults to /v2), yielding double base paths like http://petstore.swagger.io/v2/v2 when using ApiClient.BASE_URL.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
...n-jvm-spring-2-webclient/src/main/kotlin/org/openapitools/client/infrastructure/ApiClient.kt
Outdated
Show resolved
Hide resolved
a684398 to
49fae38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gives the option to access
basePath&basePathWithoutHostwith the Kotling Spring Webclient. This is already possible for many clients and the implemented approach is based on how it is implemented for the Multiplatform client, but improved in the sense that it's also possible to accessbasePathWithoutHost. For us this feature would be very useful to have as we do versioning via the path which we include as base path into the OpenAPI definitions.Apart from the feature I added additional Kotlin assertion classes to check for companions, functions & secondary constructors for testing purposes. I also added some abstract assertion classes on the way, because I realized that there was a lot of copy paste work involved during implementation of the new assertion classes.
@karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Expose base URL and base path in Kotlin JVM Spring WebClient clients via generated constants and helpers, plus a simple way to build clients with a versioned base path. This improves support for path‑based versioning and aligns with other Kotlin clients.
New Features
Refactors
Written for commit 49fae38. Summary will update on new commits.