Fix output of bin/generate-samples.sh in tmux#22743
Closed
stephenfin wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
Fix output of bin/generate-samples.sh in tmux#22743stephenfin wants to merge 2 commits intoOpenAPITools:masterfrom
bin/generate-samples.sh in tmux#22743stephenfin wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
The sleep itself has been commented out for a long time (commit 04fa53b from September 2023, to be specific). Signed-off-by: Stephen Finucane <stephen@that.guru>
Commit 23dae2b reworked this script to start capturing exceptions but the mechanism used was crude and broke output on tmux, since `/dev/pts/0` is hardcoded to a specific pseudo-terminal but each tmux pane gets its own pts. Rework this to use files instead. Signed-off-by: Stephen Finucane <stephen@that.guru>
Contributor
Author
wing328
reviewed
Jan 21, 2026
| fi | ||
|
|
||
| if [[ -n "$GENERATE_ERROR" ]]; then | ||
| if [[ $retcode -ne 0 ]] || grep -q -i "exception" "$tmpfile"; then |
Member
There was a problem hiding this comment.
thanks for the PR 👍
can you please replace exception with at org.openapitools instead to catch thrown exceptions ?
6 tasks
Member
|
merged via #22772 with updated error message and tested to confirm it works as expected |
Contributor
Author
|
Thanks, @wing328 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 23dae2b reworked this script to start capturing exceptions but the mechanism used was crude and broke output on tmux, since
/dev/pts/0is hardcoded to a specific pseudo-terminal but each tmux pane gets its own pts. Rework this to use files instead.While here, we also align some indentation with the rest of the file and remove a
sleepstatement that has been commented out for a few years.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fix generate-samples.sh output in tmux by logging to a temp file instead of /dev/pts/0. The script now correctly detects exceptions and non-zero exit codes.
Written for commit 588b3a9. Summary will update on new commits.