[Java][Spring] Fix formParams template to add support for default values when generating @RequestParam annotation for parameters included in a body with content: application/x-www-form-urlencoded#20314
Conversation
|
thanks for the PR cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08) |
|
please merge the latest master into your branch to resolve https://github.com/OpenAPITools/openapi-generator/actions/runs/12314784957/job/35166807799?pr=20314 |
|
please follow step 3 to update the samples: https://github.com/OpenAPITools/openapi-generator/actions/runs/12314784959/job/35166871083?pr=20314 |
|
Hi @wing328 Sorry for the delay. I think it is all OK now. Thanks |
|
Can it be merged now? The conflicts have been resolved. |
|
please resolve the merge conflicts when you've time |
|
@wing328 done! |
|
tests failed with updated samples via PR: #22245 https://github.com/OpenAPITools/openapi-generator/actions/runs/18904638855/job/53959854770?pr=22245 can you please review the build failure when you've time? |
formParams.mustachetemplate is lacking support for default values when generating@RequestParamannotation for parameters included in a body withcontent: application/x-www-form-urlencoded. This PR adds support for default values just the same wayqueryParams.mustachealready has.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)