Skip to content

Add vendor specific build support #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
bentheredonethat wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add vendor specific build support #83

bentheredonethat wants to merge 1 commit into from

Conversation

@bentheredonethat
Copy link
Contributor

@bentheredonethat bentheredonethat commented Sep 22, 2025

No description provided.

arnopo
arnopo reviewed Sep 24, 2025
View reviewed changes
@bentheredonethat bentheredonethat force-pushed the add-vendor-specific-build-support branch from 63ee589 to c2a74e3 Compare October 8, 2025 16:56
@bentheredonethat
Copy link
Contributor Author

bentheredonethat commented Oct 8, 2025

@arnopo i have moved to machine and updated copyright

i also added some cmake options so our vendor-specific build cases wont affect default upstream workflows

bentheredonethat
bentheredonethat commented Oct 8, 2025
View reviewed changes
@bentheredonethat bentheredonethat force-pushed the add-vendor-specific-build-support branch from c2a74e3 to 27ea3ca Compare October 8, 2025 17:29
arnopo
arnopo reviewed Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cmake folder looks good to me.
However, it seems that the machine folder needs to be reorganized if we introduce the vendor concept.
As done in several projects (Linux, Zephyr, etc.), it llok to me that having a hierarchy like vendor/platform would be better than having the vendor and platform at the same level.
Would it be possible?

@bentheredonethat bentheredonethat force-pushed the add-vendor-specific-build-support branch from 27ea3ca to 0e10bce Compare October 9, 2025 12:50
arnopo
arnopo approved these changes Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@arnopo arnopo added this to the Release V2025.10 milestone Oct 14, 2025
edmooring
edmooring approved these changes Oct 16, 2025
View reviewed changes
Copy link

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

@arnopo
Copy link
Collaborator

arnopo commented Oct 16, 2025

@bentheredonethat , please could you rebase the PR to resolve conflicts

@bentheredonethat bentheredonethat force-pushed the add-vendor-specific-build-support branch from 0e10bce to ba1b82a Compare October 16, 2025 13:50
@bentheredonethat
Copy link
Contributor Author

bentheredonethat commented Oct 16, 2025 •
edited
Loading

@arnopo i removed echo app commit because it looks like it has been fixed

tnmysh
tnmysh reviewed Oct 23, 2025
View reviewed changes
examples/legacy_apps/machine/xlnx/zynqmp_r5/helper.c
app_gic_initialize();

/* Initialize metal Xilinx IRQ controller */
ret = metal_xlnx_irq_init();
Copy link
Collaborator

@tnmysh tnmysh Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed anymore. This change should be rebased on latest branch.

@tnmysh
Copy link
Collaborator

tnmysh commented Oct 23, 2025 •
edited
Loading

@bentheredonethat, @arnopo

I think we should merge this in the next release, after downstream repo works with libmetal xlnx extension module.

Edit:

I think this commit should be removed from this PR: examples: legacy_apps: vendor: Add initial vendor port for AMD-Xilinx platforms

Other two commits we can merge. I think we should create new PR for other two commits, because it's actually fixing the bug.

Thanks.

@bentheredonethat
Copy link
Contributor Author

bentheredonethat commented Oct 27, 2025

@tnmysh sure will open new PR for the bug fixes

@bentheredonethat bentheredonethat force-pushed the add-vendor-specific-build-support branch from ba1b82a to e40760a Compare October 30, 2025 15:07
@bentheredonethat
Copy link
Contributor Author

bentheredonethat commented Oct 30, 2025

@tnmysh i moved the bug fixes to other PR which you said LGTM #88

@tnmysh
Copy link
Collaborator

tnmysh commented Oct 30, 2025

@tnmysh i moved the bug fixes to other PR which you said LGTM #88

Okay, we will merge that other PR and revisit this PR once we make demo work in 26.1 release.

@arnopo arnopo mentioned this pull request Nov 4, 2025
Merged
@arnopo arnopo requested review from arnopo and edmooring December 1, 2025 16:26
@tnmysh tnmysh marked this pull request as draft December 17, 2025 22:35
@bentheredonethat bentheredonethat force-pushed the add-vendor-specific-build-support branch from e40760a to b47455c Compare December 31, 2025 17:30
@bentheredonethat
Copy link
Contributor Author

bentheredonethat commented Dec 31, 2025

@arnopo i have rebased off latest

@bentheredonethat bentheredonethat force-pushed the add-vendor-specific-build-support branch from b47455c to 9703a1d Compare December 31, 2025 19:00
@bentheredonethat
examples: legacy_apps: vendor: Add initial vendor port for AMD-Xilinx…
c6d6316 
… platforms

Add CMake logic to build AMD-xilinx classic OpenAMP RPU Firmware demos using
Software Hardware Exchange Loop (SHEL) Flow to generate linker script.

This can be done with Lopper to generate the device tree and native CMake, Yocto AMD-Xilinx
Embedded Development Framework (EDF) or Vitis Unified IDE Workflows.

As part of this add options for vendor specific build.

By default all tests and examples will still build but add options
to make each mutable.

Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
@bentheredonethat bentheredonethat force-pushed the add-vendor-specific-build-support branch from 9703a1d to c6d6316 Compare December 31, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnmysh tnmysh tnmysh left review comments

@edmooring edmooring Awaiting requested review from edmooring

@arnopo arnopo Awaiting requested review from arnopo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release V2026.04

Development

Successfully merging this pull request may close these issues.

4 participants

@bentheredonethat @arnopo @tnmysh @edmooring