feat(nuclei): including signature manager and expectation signature (#198)#247
Merged
Conversation
b2f0e18 to
0594ab7
Compare
f2aa875 to
b514a21
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 67.52% 68.08% +0.56%
==========================================
Files 68 75 +7
Lines 3138 3353 +215
==========================================
+ Hits 2119 2283 +164
- Misses 1019 1070 +51
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
b820f79 to
f06b74f
Compare
Member
|
Testing against a locally running OAEV (docker stack on |
85648e5 to
037ca7f
Compare
There was a problem hiding this comment.
Pull request overview
This PR extends the Nuclei injector to support expectation signatures by (1) adding new predefined expectation types to the contract and (2) producing/sending signature payloads during injector execution, aligning with issue #198’s expectation-signature output requirements.
Changes:
- Add predefined expectations for
DETECTIONandPREVENTIONto Nuclei contract fields. - Add a new contract output element for
ExpectationSignature(expectation_signatures). - Integrate
pyoaev.signatures.SignatureManagerinto the Nuclei injector run flow and update external contract tests accordingly.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| nuclei/test/nuclei_contracts/test_external_contracts.py | Updates expected external contract JSON to include additional predefined expectations and the new expectation-signature output. |
| nuclei/nuclei/openaev_nuclei.py | Integrates signature building/sending into injector execution and extracts expectation types from inject content. |
| nuclei/nuclei/nuclei_contracts/nuclei_contracts.py | Adds DETECTION/PREVENTION predefined expectations and introduces the ExpectationSignature contract output. |
guzmud
approved these changes
Jul 8, 2026
7320f6d to
155d3d0
Compare
155d3d0 to
044a04b
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Proposed changes
Related issues
Checklist