feat(netexec): including signature manager and expectation signature (#200)#245
Merged
Conversation
guzmud
reviewed
Jun 2, 2026
guzmud
reviewed
Jun 2, 2026
guzmud
reviewed
Jun 2, 2026
guzmud
reviewed
Jun 2, 2026
guzmud
reviewed
Jun 3, 2026
05e00e7 to
9b624de
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 67.52% 68.07% +0.55%
==========================================
Files 68 75 +7
Lines 3138 3352 +214
==========================================
+ Hits 2119 2282 +163
- Misses 1019 1070 +51
📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
ac54aa9 to
f3778a6
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds ExpectationSignature support to the NetExec injector by integrating the pyoaev SignatureManager into the execution lifecycle and declaring ExpectationSignature as an output element for all NetExec contracts, with accompanying tests/specs.
Changes:
- Integrate
SignatureManagerintoOpenAEVNetExecInjectorto compile pre-/post-execution signatures and send them after execution. - Append an
ExpectationSignatureContractOutputElementto every NetExec contract’s outputs. - Add signature-related tests (and Gherkin-style feature descriptions) plus new signature helper constants.
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| netexec/netexec/openaev_netexec.py | Integrates SignatureManager, compiles pre/post signatures, and sends signature payloads after execution. |
| netexec/netexec/contracts/contract_outputs.py | Adds ExpectationSignature output element and appends it for all contract output sets. |
| netexec/netexec/contracts/output_registry.py | Introduces EXPECTATION_SIGNATURE constant in the output registry. |
| netexec/netexec/helpers/signature_helper.py | Adds NETEXEC_SIGNATURE_TYPES frozenset for NetExec-relevant signature types. |
| netexec/test/conftest.py | Extends pyoaev module mocking to include signature-related modules for tests. |
| netexec/test/contracts/test_expectation_signature_output.py | Tests that ExpectationSignature is always included in built contract outputs. |
| netexec/test/contracts/expectation_signature_output.feature | Feature/spec describing expected ExpectationSignature presence across contracts. |
| netexec/test/signatures/test_netexec_signature_lifecycle.py | Tests signature lifecycle integration points (compile pre/post, send payload). |
| netexec/test/signatures/netexec_signature_lifecycle.feature | Feature/spec describing the desired signature lifecycle behavior. |
| netexec/test/signatures/init.py | Package marker for signatures tests. |
| netexec/test/signatures/conftest.py | Test package conftest placeholder (currently empty). |
fbef657 to
2fcdece
Compare
Member
|
Logs while testing against a locally-running OAEV stack while launching a netexec-based atomic testing |
…il-fast Declare SignatureManager once in __init__ instead of creating it on every _send_signatures call. This avoids repeated instantiation and surfaces any pyoaev signature engine issues at injector startup.
…ming Move compile_pre_execution_signatures before the netexec tool run so that start_time is captured before execution, and compile_post_execution_signatures runs after, ensuring end_time reflects the actual tool duration.
… types Expand NETEXEC_SIGNATURE_TYPES with protocols_tested and protocols_succeeded as required by US-6 for the netexec injector execution metadata.
…a_signatures Include protocols_tested (from the parsed contract protocol) and protocols_succeeded (protocol list when returncode is 0) in the tool_output extra_signatures dict, making them available to the signature pipeline.
Read expectation_types from the inject content expectations list instead of using a hardcoded default. Falls back to ['DETECTION'] when no expectations are defined in the input data.
And also withdrawing the unecessary target_meta from the payload building
fdc44b8 to
ab987b7
Compare
guzmud
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds ExpectationSignature support to the Netexec injector.
Registers
ExpectationSignatureas a contract output across all Netexec contract typesIntegrates
SignatureManager(from pyoaevfeat/us-int-1-signature-lifecycle) intoOpenAEVNetExecInjector:__init___build_target_meta()maps assets/asset groups from inject dataDETECTIONandPREVENTIONexpectation typesAdds
NETEXEC_SIGNATURE_TYPESfrozenset insignature_helper.pyTesting Instructions
Related issues
Checklist
Further comments