fix: keep SearchBox icon and input on one row at ≤480px#28
Merged
Conversation
The mobile media query gave .oc-search-box__input flex: 1 1 100%, forcing it onto its own flex line and pushing the order:0 icon to the line above. The input now flexes normally (flex: 1 1 auto) so it shares the first row with the icon, and only the button wraps to a full-width second row. Fixes #27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SearchBoxicon detached onto its own row, leaving the magnifying-glass icon floating above the input.@media (max-width: 480px)block gave.oc-search-box__inputflex: 1 1 100%, forcing it onto its own flex line. Withflex-wrap: wrap, theorder: 0icon was pushed onto the line above it.flex: 1 1 autoso it shares the first row with the icon; only the button keepsflex: 1 1 100%and wraps to a full-width second row.Test plan
<SearchBox placeholder="Search…" />at ≤480px (e.g. 390px) and confirm[icon + input]on one row,[button]full-width below.npm run buildpasses.