Conversation
Signed-off-by: Pascal Minder <p.minder@evtec.ch>
| @@ -0,0 +1,1791 @@ | |||
| ======================================================================================================================== | |||
|
|
|||
| nftables-1.0.2.tar.bz2 | |||
There was a problem hiding this comment.
Should the name be without the file extension tar.bz2?
There was a problem hiding this comment.
yes please remove the extensions
There was a problem hiding this comment.
Is it possible to set the name of the package directly in FOSSology, or has it to be manually altered?
There was a problem hiding this comment.
you do not need to do that, I will take care of it.
| PackageName: nftables-1.0.2.tar.bz2 | ||
| PackageFileName: nftables-1.0.2.tar.bz2 | ||
| SPDXID: SPDXRef-upload450 | ||
| PackageDownloadLocation: NOASSERTION |
There was a problem hiding this comment.
Should this be filled out?
And should we add a ExternalRef
There was a problem hiding this comment.
yes please, this will make the SPDX files self contained
There was a problem hiding this comment.
Can I change both in FOSSology itself, or do I need to edit the exported files manually?
There was a problem hiding this comment.
No you do not need to do that, I can do that. Not to load you with postprocessing. Since you are providing the Readme file.
But if you like you can aslo add the purl in the following field (in the "Conf" menu, please do not forget to press the "submit" button in the bottom of the page):
|
A very warm welcome to you @evtecag. Thank you very much for your contribution, I will look into it and provide you feedback. |
OliverFendt
left a comment
OliverFendt
left a comment
There was a problem hiding this comment.
Excellent contribution @evtecag, especially the CC-BY-SA acknowledgment is very well done. I only have a few comments.
|
|
||
| <Copyright notices> | ||
|
|
||
| <notices> |
There was a problem hiding this comment.
Please check why there are no copyright statements in the files, did you forget to run the copyright agent?
I have found the follwing copyrights:
Copyright notices
Copyright(C) 2018 Phil Sutter phil@nwl.cc
Copyright © 2012-2015 Dan Nicholson dbn.lists@gmail.com
Copyright © 2008-2014 Patrick McHardy kaber@trash.net Copyright © 2013-2018 Pablo Neira Ayuso pablo@netfilter.org
Copyright © 2004 Scott James Remnant scott@netsplit.com.
Copyright Red Hat
Copyright 2011-2015, 2017 Free Software Foundation, Inc.
Copyright 1992-2018 Free Software Foundation, Inc.
Copyright 1991-1997, 1999-2016 Free Software Foundation, Inc.
Copyright (c) Red Hat GmbH. Author: Florian Westphal fw@strlen.de
Copyright (c) 2021 Pablo Neira Ayuso pablo@netfilter.org
Copyright (c) 2019 Pablo Neira Ayuso pablo@netfilter.org
Copyright (c) 2018 Máté Eckl ecklm94@gmail.com
Copyright (c) 2017 Phil Sutter phil@nwl.cc
Copyright (c) 2017 Eric Leblond eric@regit.org
Copyright (c) 2017 Elise Lennion elise.lennion@gmail.com
Copyright (c) 2016 Pablo Neira Ayuso pablo@netfilter.org
Copyright (c) 2016 Anders K. Pedersen akp@cohaesio.com
Copyright (c) 2015 Pablo Neira Ayuso pablo@netfilter.org
Copyright (c) 2015 Arturo Borrero Gonzalez arturo@netfilter.org
Copyright (c) 2015 Arturo Borrero Gonzalez arturo@debian.org
Copyright (c) 2014 Patrick McHardy kaber@trash.net
Copyright (c) 2013-2017 Pablo Neira Ayuso pablo@netfilter.org
Copyright (c) 2013-2015 Pablo Neira Ayuso pablo@netfilter.org
Copyright (c) 2013 Pablo Neira Ayuso pablo@netfilter.org
Copyright (c) 2008-2012 Patrick McHardy kaber@trash.net
Copyright (c) 2008 Patrick McHardy kaber@trash.net
Copyright (c) 2007-2012 Patrick McHardy kaber@trash.net
Copyright (c) 2007-2008 Patrick McHardy kaber@trash.net
Copyright (c) 2005 Evgeniy Polyakov johnpol@2ka.mxt.ru
Copyright (C) 2014 Free Software Foundation, Inc.
Copyright (C) 2012 Free Software Foundation, Inc.
Copyright (C) 2011-2020 Free Software Foundation, Inc.
Copyright (C) 2011 Free Software Foundation, Inc.
Copyright (C) 2010-2020 Free Software Foundation, Inc. Written by Peter Rosin peda@lysator.liu.se.
Copyright (C) 2010-2015 Free Software Foundation, Inc.
Copyright (C) 2009-2020 Free Software Foundation, Inc.
Copyright (C) 2006-2020 Free Software Foundation, Inc.
Copyright (C) 2004-2020 Free Software Foundation, Inc.
Copyright (C) 2004-2015 Free Software Foundation, Inc.
Copyright (C) 2004-2005, 2007-2009, 2011-2015 Free Software Foundation, Inc. Written by Gary V. Vaughan, 2004
Copyright (C) 2004-2005, 2007-2008, 2011-2015 Free Software Foundation, Inc. Written by Gary V. Vaughan, 2004
Copyright (C) 2004-2005, 2007, 2009, 2011-2015 Free Software Foundation, Inc. Written by Scott James Remnant, 2004.
Copyright (C) 2004, 2011-2015 Free Software Foundation, Inc. Written by Scott James Remnant, 2004
Copyright (C) 2003-2020 Free Software Foundation, Inc.
Copyright (C) 2002-2020 Free Software Foundation, Inc.
Copyright (C) 2001-2020 Free Software Foundation, Inc.
Copyright (C) 1999-2020 Free Software Foundation, Inc. Written by Tom Tromey tromey@cygnus.com.
Copyright (C) 1999-2020 Free Software Foundation, Inc.
Copyright (C) 1999 Paul `Rusty' Russell & Michael J. Neuling
Copyright (C) 1997-2020 Free Software Foundation, Inc.
Copyright (C) 1996-2020 Free Software Foundation, Inc. Originally written by Fran,cois Pinard pinard@iro.umontreal.ca, 1996.
Copyright (C) 1996-2020 Free Software Foundation, Inc.
Copyright (C) 1996-2015 Free Software Foundation, Inc.
Copyright (C) 1996-2001, 2003-2015 Free Software Foundation, Inc. Written by Gordon Matzigkeit, 1996
Copyright (C) 1994-2020 Free Software Foundation, Inc.
Copyright (C) 1994 X Consortium
Copyright (C) 1992-1996, 1998-2012 Free Software Foundation, Inc.
Copyright (C) 1989, 1991 Free Software Foundation, Inc.
Copyright (C) 1984, 1989-1990, 2000-2015, 2018-2021 Free Software Foundation, Inc.
Copyright 2008-2014 Patrick McHardy kaber@trash.net Copyright 2013-2018 Pablo Neira Ayuso pablo@netfilter.org
(C) Steve Whitehouse 1999
(C) Copyright 2003 by Mike Frantzen frantzen@w4g.org
(C) Copyright 2000-2003 by Michal Zalewski lcamtuf@coredump.cx
(C) 2014 by Ana Rey Botello anarey@gmail.com
(C) 2012 by Pablo Neira Ayuso pablo@netfilter.org
(C) 2002 David Woodhouse dwmw2@infradead.org
(C) 1999 Andrea Arcangeli andrea@suse.de
There was a problem hiding this comment.
We performed the curation on our internal package in FOSSology, uploaded the corresponding upstream package to FOSSology, and reused the curation data from the internal package during the upload.
It seems that the copyright information are not reused, and if I let the scan run again, I have to clean up the copyright manually.
Is this an expected behaviour or did I use the wrong reuse settings?
There was a problem hiding this comment.
I see, you did not run the Copyright scanner (the third option under topic 8, as far as I know copyright are not taken over when you do the reuse.
For verification your workflow was as follows:
- You already had a previous version of nftables curated.
- You want to curate the version 1.0.2 with making use of the reuse feature.
- you uploaded 1.0.2 and selected the reuse configuration shown.
- you didnt select in for the upload a scanner to run.
That's why no LicenseInfoInFile, CopyrightNotice and LicenseComment shows up in 1.0.2 . You should select exactly the same scanners for 1.0.2. as you have selected in the r0-patched version.
I hope that helps, if not please reach out to me (oliver dot fendt at fossea dot de) then we can arrange a meeting
analysed-packages/nftables/version-1.0.2/nftables-1.0.2-OSS-disclosure.txt
Outdated
Show resolved
Hide resolved
analysed-packages/nftables/version-1.0.2/nftables-1.0.2-OSS-disclosure.txt
Show resolved
Hide resolved
analysed-packages/nftables/version-1.0.2/nftables-1.0.2-OSS-disclosure.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
My commenty in the OSS-disclosure file are also valid in this file
| FileChecksum: SHA1: 18fa48a7ed581b147776213368ae1aafd82509c2 | ||
| FileChecksum: SHA256: c17bc4fa5b2434c6f283ffcb2312e5bf3c7cdf5787b79505f094d8de734ac53e | ||
| FileChecksum: MD5: d1a78fdd879a263a5e0b42d1fc565e79 | ||
| LicenseConcluded: LicenseRef-License-of-GNU-Licenses |
There was a problem hiding this comment.
Can you alos please check whether you have the comments enabled in the SPDX report.
Additionally it is somehow strange that there is LicenseInfoInFile: NOASSERTION the scanners should have matched a license there. The same applies also in the following files like nftables-1.0.2/src/proto.c etc.
There was a problem hiding this comment.
I have the following settings for the package in FOSSology:
The shown settings should be the right ones?
2 participants
We would like to contribute the curated nftables-1.0.2 licence information.
Since it is our first contribution, I highlighted some differences between previous contribution and our uploaded files. Could you give us a hint if we need to add the missing information or if they are not relevant?
Thank you very much for your review.