Skip to content

Merge pull request #411 from Open-J-Proxy/copilot/review-unanswered-c…

f39948b
Select commit
Loading
Failed to load commit list.
Merged
SonarQubeCloud / SonarCloud Code Analysis failed Apr 7, 2026 in 27s

Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required β‰₯ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 476 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a default case to this switch.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbEYvX_PW5NlwxUj&open=AZ0nDbEYvX_PW5NlwxUj&pullRequest=343

Check warning on line 253 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConfigurationTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "config" local variable.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0ljrE8Ydn-O0VHojbC&open=AZ0ljrE8Ydn-O0VHojbC&pullRequest=343

Check warning on line 239 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "Thread.sleep()".

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbEYvX_PW5NlwxUg&open=AZ0nDbEYvX_PW5NlwxUg&pullRequest=343

Check warning on line 257 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbEYvX_PW5NlwxUa&open=AZ0nDbEYvX_PW5NlwxUa&pullRequest=343

Check warning on line 23 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbEYvX_PW5NlwxUf&open=AZ0nDbEYvX_PW5NlwxUf&pullRequest=343

Check failure on line 112 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/QueryCacheMetricsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbGyvX_PW5NlwxU3&open=AZ0nDbGyvX_PW5NlwxU3&pullRequest=343

Check warning on line 438 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "cache" which hides the field declared at line 25.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbEYvX_PW5NlwxUi&open=AZ0nDbEYvX_PW5NlwxUi&pullRequest=343

Check warning on line 215 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheEndToEndTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "config1" local variable.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0rYRfkQOAsUKtXOlOO&open=AZ0rYRfkQOAsUKtXOlOO&pullRequest=343

Check warning on line 108 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbEYvX_PW5NlwxUX&open=AZ0nDbEYvX_PW5NlwxUX&pullRequest=343

Check failure on line 115 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/QueryCacheMetricsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbGyvX_PW5NlwxU4&open=AZ0nDbGyvX_PW5NlwxU4&pullRequest=343

Check warning on line 160 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheEndToEndTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "config" local variable.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0rYRfkQOAsUKtXOlON&open=AZ0rYRfkQOAsUKtXOlON&pullRequest=343

Check warning on line 22 in ojp-server/src/test/java/org/openjproxy/grpc/server/util/DatasourceNameExtractorTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace these 6 tests with a single Parameterized one.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ1ecr1GMbZ4NfML-U9H&open=AZ1ecr1GMbZ4NfML-U9H&pullRequest=343

Check warning on line 322 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbEYvX_PW5NlwxUb&open=AZ0nDbEYvX_PW5NlwxUb&pullRequest=343

Check warning on line 11 in ojp-server/src/main/java/org/openjproxy/grpc/server/cache/QueryResultCacheRegistry.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

A Singleton implementation was detected. Make sure the use of the Singleton pattern is required and the implementation is the right one for the context.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0g3V2clnQ8SVcqrCpe&open=AZ0g3V2clnQ8SVcqrCpe&pullRequest=343

Check warning on line 331 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheEndToEndTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "config" local variable.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0rYRfkQOAsUKtXOlOR&open=AZ0rYRfkQOAsUKtXOlOR&pullRequest=343

Check failure on line 106 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/QueryCacheMetricsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbGyvX_PW5NlwxU1&open=AZ0nDbGyvX_PW5NlwxU1&pullRequest=343

Check warning on line 107 in ojp-server/src/main/java/org/openjproxy/grpc/server/cache/CacheSecurityValidator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this if-then-else statement by a single return statement.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0mgbpr7Lq6732fG5w4&open=AZ0mgbpr7Lq6732fG5w4&pullRequest=343

Check failure on line 454 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CachePerformanceBenchmarkTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add at least one assertion to this test case.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nD9ommxdebns9OIqg&open=AZ0nD9ommxdebns9OIqg&pullRequest=343

Check warning on line 43 in ojp-server/src/main/java/org/openjproxy/grpc/server/cache/CacheSecurityValidator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invoke method(s) only conditionally.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0mgbpr7Lq6732fG5w2&open=AZ0mgbpr7Lq6732fG5w2&pullRequest=343

Check warning on line 72 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CachedQueryResultTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0gq4a8GCUUzfFYi2He&open=AZ0gq4a8GCUUzfFYi2He&pullRequest=343

Check warning on line 28 in ojp-server/src/main/java/org/openjproxy/grpc/server/cache/SqlTableExtractor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0iGM-Qx1YWwwWtnX4p&open=AZ0iGM-Qx1YWwwWtnX4p&pullRequest=343

Check warning on line 132 in ojp-server/src/main/java/org/openjproxy/grpc/server/cache/QueryResultCacheRegistry.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

%n should be used in place of \n to produce the platform-specific line separator.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0g3V2clnQ8SVcqrCpf&open=AZ0g3V2clnQ8SVcqrCpf&pullRequest=343

Check warning on line 372 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbEYvX_PW5NlwxUc&open=AZ0nDbEYvX_PW5NlwxUc&pullRequest=343

Check failure on line 109 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/QueryCacheMetricsTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbGyvX_PW5NlwxU2&open=AZ0nDbGyvX_PW5NlwxU2&pullRequest=343

Check warning on line 425 in ojp-server/src/test/java/org/openjproxy/grpc/server/cache/CacheConcurrencyTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'public' modifier.

See more on https://sonarcloud.io/project/issues?id=Open-J-Proxy_ojp&issues=AZ0nDbEYvX_PW5NlwxUd&open=AZ0nDbEYvX_PW5NlwxUd&pullRequest=343