make the ojp-server docker image leaner

[matheusandre1]

Closes #49 , This reduces it, but is that all there is to it?

[rrobetti]

@matheusandre1 have you run the integration tests against the new image? Would be great if you could run all integration tests against the old image and then against the new one to compare.

[matheusandre1]

eclipse-temurin:22-jre (Standard): 494.67 MB
eclipse-temurin:22-jre-alpine (Alpine): 360.5 MB

[matheusandre1]

[rrobetti]

@matheusandre1 have you run the integration tests against the docker image? Currently, in the CI workflow we don't run tests against the docker image, we run OJP Server as an executable JAR. That is why I am insisting on testing it locally.

[matheusandre1]

Yes, I rotated and built an image on top.

[matheusandre1]

[rrobetti]

@matheusandre1 , the integration tests I'm referring to are the ones that are in ojp-jdbc and run against the real databases. there's a video explaining it here: https://youtu.be/KFR-DGmc2A0?si=wxZe-PcK5QP0wjoM

[matheusandre1]

I'll check it out, thanks for reminding me about that, I believe the CI is costly for you.

[rrobetti]

I'll check it out, thanks for reminding me about that, I believe the CI is costly for you.

@matheusandre1 it's not about the cost, it is that the CI does not use docker images, it runs an executable JAR only at the moment.

[matheusandre1]

I'll do that tonight, I'm having trouble testing it, I'm using ACT and it's gotten worse lol

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rrobetti]

@matheusandre1 any progress on this?

[matheusandre1]

I realized I had to put together a script to shoot it; I tried to record a video, but it went over 10 minutes.

[matheusandre1]

Can you grab the branch and check it so I'm not messing anything up?

[rrobetti]

@matheusandre1 you need to create the new docker image locally and run it, then you need to run first the H2 tests on ojp-jdbc-driver module
mvn test -pl ojp-jdbc-driver -Dgpg.skip=true -DenableH2Tests=true

This will quickly show you issues. That is how we run tests in the main CI workflow.

Then you need to run each database on docker, for example postgres and run the postgres integration tests
mvn test -pl ojp-jdbc-driver -Dgpg.skip=true -DenablePostgresTests=true

Once you get the first one done you'll fly by as per it is just more of the same for the other DBs.

Leave DB2 and SQL Server for last as per they need extra setup (creating user, giving permissions), you can find how to run each database here: https://github.com/Open-J-Proxy/ojp/blob/main/documents/code-contributions/setup_and_testing_ojp_source.md

We do need to test all databases locally before we can merge this change.