Update solution for Q10: Calculate Covariance Matrix (medium)#138
Closed
adtygan wants to merge 1 commit intoOpen-Deep-ML:mainfrom
Closed
Update solution for Q10: Calculate Covariance Matrix (medium)#138adtygan wants to merge 1 commit intoOpen-Deep-ML:mainfrom
adtygan wants to merge 1 commit intoOpen-Deep-ML:mainfrom
Conversation
Fix naming issue for `n_observations` and `n_features`
adtygan
changed the title
Owner
|
would you be able to make these changes in the new repo format |
Author
|
Hi, sorry your comment slipped through my notifs. Could you explain what the new repo format is? |
Collaborator
|
we have changed the layout of the questions so I made the changes to the repo, thank you for letting me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the solution,
n_featuresandn_observationsare used in the opposite sense.n_featureswas defined as the total number of observations and vice versa. I swapped the definition and how it is used throughout the code. Think this would improve clarity of the solution.