Skip to content

Highlight changing expressions in Live Watch#991

Open
omarArm wants to merge 5 commits into
mainfrom
highlightLiveWatch
Open

Highlight changing expressions in Live Watch#991
omarArm wants to merge 5 commits into
mainfrom
highlightLiveWatch

Conversation

@omarArm
Copy link
Copy Markdown
Collaborator

@omarArm omarArm commented May 12, 2026

Fixes

Changes

  • Now changing expressions will get highlighted in the Live Watch

Screenshots

image

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • [] 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@omarArm
Copy link
Copy Markdown
Collaborator Author

omarArm commented May 12, 2026

@JonatanAntoni @thorstendb-ARM I acknowledge that there might be some opinions on which parts of the expression should get highlighted. We can discuss it together in a meeting, but these are just some details that can easily be changed

@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 12, 2026

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/views/live-watch/live-watch.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds change-highlighting behavior to the Live Watch tree so users can more easily spot updated values during debugging (fixes #850).

Changes:

  • Introduces a highlightedLabel on Live Watch values and uses it to render highlighted tree item labels.
  • Splits evaluation into initial evaluation vs per-node refresh evaluation to detect value changes.
  • Updates and extends Jest tests to cover highlight vs non-highlight behavior on refresh.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
src/views/live-watch/live-watch.ts Adds highlightedLabel support and refresh-time change detection to apply label highlighting.
src/views/live-watch/live-watch.test.ts Updates mocks for renamed evaluation methods and adds tests for highlight behavior.

Comment thread src/views/live-watch/live-watch.ts
Comment thread src/views/live-watch/live-watch.test.ts Outdated
Comment thread src/views/live-watch/live-watch.ts
Comment thread src/views/live-watch/live-watch.ts
Comment thread src/views/live-watch/live-watch.ts
omarArm and others added 3 commits May 12, 2026 13:15
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@omarArm omarArm force-pushed the highlightLiveWatch branch from 84a56f4 to 9aa36f2 Compare May 13, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants