Conversation
a5c5e7d to
cf7edb6
Compare
|
I completed the implementation of PCAN that supports all interfaces. Anyway I dont have any PCAN to test it. |
I suspect this lint was added to clippy since we last merged to main, and that the CI/CD pipeline uses the latest clippy release.
a850b7c to
eec1282
Compare
Fedora PCAN-Basic installation instructionssudo dnf install kernel-devel popt-devel
tar -xzvf peak-linux-driver-8.16.0.tar.gz
cd peak-linux-driver-8.16.0/
make KERNEL_LOCATION=/usr/src/kernels/6.5.9-200.fc38.x86_64/ clean
EXTRA_CFLAGS=-Wno-error=incompatible-pointer-types make KERNEL_LOCATION=/usr/src/kernels/6.5.9-200.fc38.x86_64/ NET=NETDEV_SUPPORT all
sudo make KERNEL_LOCATION=/usr/src/kernels/6.5.9-200.fc38.x86_64/ installQuestion: Should this be a netdev or chardev network device? The peak driver documentation says they now default to using chardev.
|
builds, driver works, no functional test (no pcan available) --------- Co-authored-by: Jannes Brands <jannes@jannesbrands.de> Co-authored-by: Austin Gill <notgnoshi@gmail.com>
Including pcan support in the tests requires the test environment have libpcanbasic available, which has to be built from source.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ag/tracing #14 +/- ##
==============================================
- Coverage 40.67% 39.13% -1.55%
==============================================
Files 8 8
Lines 563 575 +12
==============================================
- Hits 229 225 -4
- Misses 334 350 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dc2d922 to
cdbdb18
Compare
I don't have a way of testing this, so I have no idea how far off it is.