Fix TimeDate SPN 962 day scaling#687
Open
sujandumaru wants to merge 1 commit into
Open
Conversation
sujandumaru
commented
May 15, 2026
sujandumaru
force-pushed
the
fix-time-date-spn-962
branch
from
5b04e3b to
0fbfdac
Compare
ad3154
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes #634
This updates the TimeDateInterface SPN 962 day conversion so the raw quarter-day-scaled value is decoded as the correct calendar day. Raw SPN 962 values like
37,38,39, and40now decode to day10with normalizedquarterDaysvalues0,1,2, and3.The transmit path was also updated to use the inverse conversion, so sending
day = 10withquarterDays = 0/1/2/3emits raw SPN 962 values37/38/39/40.I also added focused unit coverage for both receiving and sending SPN 962 values, and refactored the TimeDate tests to share common fixture setup and SPN 962 test cases.
How has this been tested?
cmake -S . -B build -DBUILD_TESTING=ON cmake --build build ctest --test-dir build -R TimeDateTest --output-on-failure ctest --test-dir build --output-on-failure