[Build] : fix detection of standard threading model support by the toolchain#653
Merged
GwnDaan merged 2 commits intoOpen-Agriculture:mainfrom Dec 27, 2025
Conversation
Contributor
Author
|
@GwnDaan, please review this changes when you have a time, thank you. Thanks for any questions and additions. |
VzdornovNA88
force-pushed
the
hotfix/Automated_build_for_testing_no_threads_641
branch
from
1e3a7ed to
7302537
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In accordance with issue #652 , I changed the method of detecting support for the standard threading model, as well as added fake sources to the target paths for examples that, in my opinion, were missed.
Fixes #652
I tested this locally with #647 (with locally installed gcc 10 for arm and clang 13 for arm) and another locally installed gcc 13 toolchain for x86_64 (ubuntu 20.04).
It should be understood that I tested switching between toolchains and the correct state of the CAN_STACK_DISABLE_THREADS flag after configuring the build, the important point is that I do not pass this parameter to the command as a user settings, otherwise the whole check will be meaningless. As for the paths to the fake sources, here I checked for the presence of the main error in the build, which we ourselves defined in these sources.