Add support for passive/active frames #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `passive_frames` & `active_frames` Animation properties (uint). These properties store values from the meta.txt - Add `active` Animation property to store the animation state, updated from the UI. - Remove `total_frames_number` Animation property (unused). - Use the `Animation::get_total_frames_number` function to return frames number based on the animation state (`active` property) instead of returning the `total_frames_number` property value. - Update `Animation::next_frame` function to return the next frame depending of the animation state (`active` property). - Create `AnimationWallet::set_active` function tu update state for every animations. - UI: Add Checkbox in animation popup to update animation state. - UI: Add MenuItems in Tools menu to change every animations states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Another contribution to support passive/active frames. By default animations are displayed only with passive frames.
Active frames can be enabled (or disabled) in the animation popup via the added checkbox, or in the Tools menu to enable/disable active frames globally for all animations.
Here is major changes of this PR:
passive_frames&active_framesAnimation properties (uint). These properties store values from the meta.txtactiveAnimation property to store the animation state, updated from the UI.total_frames_numberAnimation property (unused).Animation::get_total_frames_numberfunction to return frames number based on the animation state (activeproperty) instead of returning thetotal_frames_numberproperty value.Animation::next_framefunction to return the next frame depending of the animation state (activeproperty).AnimationWallet::set_activefunction tu update state for every animations.