Arch: Protocol violation due to internal polling in comet_ask#7
Merged
Conversation
OneStepAt4time
commented
Apr 11, 2026
Owner
Author
OneStepAt4time
left a comment
OneStepAt4time
left a comment
There was a problem hiding this comment.
Excellent architectural refactor. Decoupling the polling loop from comet_ask prevents transport timeouts during deep research. Test coverage accurately reflects the new non-blocking behavior. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2. Decouples the comet_ask command from the polling loop to prevent MCP timeout during deep research. The client should now use comet_poll or comet_wait after comet_ask to retrieve the response.