fix(dashboard): update test assertions for CSS variable migration#4079
Merged
Conversation
added 2 commits
May 23, 2026 12:23
PipelineStatusBadge.test.tsx and ConfirmDialog.test.tsx still asserted old raw Tailwind color classes (text-emerald-400, text-red-300) that were replaced with CSS variable tokens in PR #4077.
Tests asserted old hardcoded Tailwind classes that were migrated to CSS variable design tokens. Update all four assertions: - PipelineStatusBadge.test: text-emerald-400 → text-[var(--color-success-glow)] - ConfirmDialog.test: text-red-300 → text-[var(--color-danger-glow)] - EmptyState.test: text-red-300 → text-[var(--color-danger-glow)] - LiveStatusIndicator.test: bg-emerald-500/10 → bg-[var(--color-success)]/10
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Review: PR #4079 — Test Assertion Fix (CSS var migration follow-up)
Two-line fix: test selectors updated to match new CSS var class names from #4077.
text-emerald-400→text-[var(--color-success-glow)]✅text-red-300→text-[var(--color-danger-glow)]✅
Missed in original migration. Correct follow-up. All CI green.
9 Merge Gates — All Pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two test files still asserted old raw Tailwind color classes that were replaced with CSS variable tokens in PR #4077.
Fixes:
PipelineStatusBadge.test.tsx—text-emerald-400→text-[var(--color-success-glow)]ConfirmDialog.test.tsx—text-red-300→text-[var(--color-danger-glow)]Verification