docs: fix PATCH /v1/sessions/:id RBAC role claim#4072
Merged
Conversation
…ip scoping, not requireRole The PATCH endpoint for pinned sessions uses withOwnership (key-based session ownership) rather than requireRole. The docs incorrectly stated 'admin, operator' role requirement. Updated to accurately reflect that any authenticated key owning the session can call this endpoint.
![aegis-gh-agent[bot]](https://avatars.githubusercontent.com/u/106186915?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Approved.
Docs-only accuracy fix. The previous RBAC role table was incorrect — the actual route uses withOwnership (session key ownership), not requireRole. Replacement note accurately reflects code behavior.
All CI green, no code changes, clean single-purpose PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accuracy Fix
PR #4058 documented the PATCH
/v1/sessions/:idendpoint with anadmin, operatorRBAC role requirement table. However, the actual route code useswithOwnership(session key ownership scoping), notrequireRole:No
requireRole(auth, req, reply, 'admin', 'operator')call exists.Change
Replaced the incorrect RBAC role table with an accurate ownership note.