Add custom app group name property#245
Conversation
|
I just tested it and works. Thank you. |
| "@expo/image-utils": "^0.3.22" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@rgomezp i'd be happy to keep it, if it wasn't preventing me from utilizing it. when testing/building things with Expo 53 yesterday it kept failing cause I use npm and yarn wasn't found for this prepare script. As I understand it, the npm invocation should work with either package manager whereas yarn does not
| "build": "npm run lint && rm -rf build && tsc && cp -a support/serviceExtensionFiles build/support/", | ||
| "lint": "eslint . --ext .ts", | ||
| "prepare": "yarn run build" | ||
| "prepare": "npm run build" |
There was a problem hiding this comment.
@rgomezp i'd be happy to keep it, if it wasn't preventing me from utilizing it. when testing/building things with Expo 53 yesterday it kept failing cause I use npm and yarn wasn't found for this prepare script. As I understand it, the npm invocation should work with either package manager whereas yarn does not
| assert.ok(config.ios?.bundleIdentifier, "Missing 'ios.bundleIdentifier' in app config.") | ||
| config.extra = getEasManagedCredentialsConfigExtra(config as ExpoConfig); | ||
| return config; | ||
| } |
There was a problem hiding this comment.
This can be simplified. Also if they provide an appGroupName we don't check for bundleId. props is optional anyway
|
That would be a perfect merge. I'm using the commit as package in my project and it solved the issue. I hope it gets accepted very soon ! |
|
@rgomezp is it possible to merge this ? I think it can be clean code later. A lot of people have this issue at the moment |
|
@jkasten2 cc |
|
please merge this |
fadi-george
force-pushed
the
main
branch
6 times, most recently
from
ba2fee0 to
e7a4e6e
Compare
|
Hey, thanks for making this contribution to the project. The team merged #270, which adds support for customizing the app group name and as a result, have closed this PR since it's no longer needed. |
6 participants
Description
One Line Summary
Adds a plugin property
appGroupNameto customize the app group name in accordance with https://documentation.onesignal.com/docs/ios-sdk-setup#use-custom-app-group-name.Details
Motivation
Why is this code change being made? Or what is the goal of this PR?
Provide functionality expected by OneSignal's iOS SDK.
Testing
Manual testing
I tested this change with my own Expo-based application on a real device, and I was able to successfully send and receive a push notification from OneSignal.
Checklist
Overview
Testing
both Android andiOSFinal pass