Skip to content

Work around a Chronic bug #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WizardOfOgz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Work around a Chronic bug #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/has_safe_dates/core_ext.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ def read_date
# Otherwise the original #read_date method is invoked.
def read_time
if ActiveRecord::Base.has_safe_fields_config[object.class.base_class] && ActiveRecord::Base.has_safe_fields_config[object.class.base_class][:fields].include?(name)
"#{ values.values_at(1,2,3).join("-")} #{ values.values_at(4,5).join(":") }" # Convert multiparameter parts into a Time string, e.g. "2011-4-23 12:34", return it, and allow CoreExt methods handle the result.
date = values.values_at(1,2,3).join("-")
time = values.values_at(4,5).map{ |digit| "%02i" % digit }.join(":") # Zero-pad the hour and minute values to work around a Chronic bug, see https://github.com/mojombo/chronic/issues/314
"#{ date } #{ time }" # Convert multiparameter parts into a Time string, e.g. "2011-4-23 12:34", return it, and allow CoreExt methods handle the result.
else
super # has_safe_dates is not enabled for the current field, so invoke the super method (original #read_time method).
end
Expand Down