Skip to content

Fix(keylayout): don’t append actions twice for a given key/key_name combination #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
notpushkin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(keylayout): don’t append actions twice for a given key/key_name combination #211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions kalamine/generators/keylayout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,16 @@ def append_actions(key: str, symbol: str, actions: List[Tuple[str, str]]) -> Non
ret_actions.append(f"<!--{key_name[1:]} -->")
continue

already = []
for i in [Layer.BASE, Layer.SHIFT, Layer.ALTGR, Layer.ALTGR_SHIFT]:
if key_name == "spce" or key_name not in layout.layers[i]:
continue

key = layout.layers[i][key_name]
if key in already:
continue
already.append(key)

if i and key == layout.layers[Layer.BASE][key_name]:
continue
if key in layout.dead_keys:
Expand Down