Add Makefile target coverage-report for CI-friendly coverage output (fixes #137)#142
Add Makefile target coverage-report for CI-friendly coverage output (fixes #137)#142Santosh69 wants to merge 2 commits intoOneBusAway:mainfrom
Conversation
|
|
|
Hi @Ahmedhossamdev and @team 👋 , I’ve submitted this PR for issue #137. If there are any follow-up improvements, related issues, or areas where this change can be expanded, I’d be happy to help. |
aaronbrethorst
left a comment
aaronbrethorst
left a comment
There was a problem hiding this comment.
Please remove the unrelated AI generated changes from this PR and resubmit
| } | ||
| } | ||
|
|
||
| // Return the most common direction found in the directions map |
There was a problem hiding this comment.
This comment doesn't add any value. It feels like it was generated by an overeager generative AI system.
| direction = stop.Direction.String | ||
| } | ||
| // Use the shared OBA direction pipeline (precomputed DB or shape-based fallback) for consistency. | ||
| direction := api.calculateStopDirection(ctx, stop.ID) |
There was a problem hiding this comment.
This is not related to the state of purpose of your PR. Please revert and move it into a different commit
| valid := map[string]bool{ | ||
| "N": true, "NE": true, "E": true, "SE": true, | ||
| "S": true, "SW": true, "W": true, "NW": true, | ||
| "UNKNOWN": true, // <--- correct fallback for THIS repo |
There was a problem hiding this comment.
I would appreciate it if you'd remove obvious signs of these changes being generated by an AI agent
|
please review our policy on AI generated contributions and reopen when you're ready: https://opentransitsoftwarefoundation.org/2025/12/our-policy-on-ai-generated-contributions/ |
3 participants
Summary
This PR adds a new Makefile target
coverage-reportthat prints a CI-friendly coverage summary directly to the terminal.coverage-reportcoveragetarget (HTML output) is left unchanged.What I changed
Added this target to
Makefile:Updated
.PHONYto includecoverage-report.Why
Issue #137 requests a terminal-friendly coverage output.
The current Makefile only generates an HTML report.
This new target provides a simple, script-friendly summary without replacing the existing workflow.
How I tested (local)
make coverage-report→ confirmed coverage output is printed for all packages.coverage.outis generated.make coverage→ confirmed the HTML report is still produced successfully.Screenshots
Terminal output from
make coverage-report:Makefile change (
coverage-reporttarget):HTML coverage report generated by
make coverage:Fixes #137