This repository was archived by the owner on Sep 21, 2021. It is now read-only.
Open
Conversation
Update the README.md to reflect the change to the get call
|
|
sumurthy
reviewed
Aug 28, 2018
Contributor
sumurthy
left a comment
sumurthy
left a comment
There was a problem hiding this comment.
Is this just a rename? I don't see the relation between issue explained and the change made here.
Author
|
The old get within the token manager is being called and only returns a token if it is valid. If the token is expired this method attempts to delete that same token, by calling the delete method. The delete method in-turn called the old get method. So the code ends up going out of stack. By renaming this method to getValidToken, this method will return a valid token only. Using the same code now, when the token is expired and the delete is called the delete will call the super get that does not validate the token, it just returns a token if found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In IE or the outlook desktop the token can be deleted if the token is expired. The get method to get the token actual token without the expire check is over written, therefore the calls to the get method that checks to the token to be expired is being called in the delete method and the infinite loop is created.