Skip to content

Change state-history default to zero for path archive#4197

Merged
joshuacolvin0 merged 3 commits intomasterfrom
default-state-history
Jan 16, 2026
Merged

Change state-history default to zero for path archive#4197
joshuacolvin0 merged 3 commits intomasterfrom
default-state-history

Conversation

@amsanghi
Copy link
Copy Markdown
Contributor

@amsanghi amsanghi commented Jan 5, 2026

Fixes: NIT-4222

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.99%. Comparing base (c8c5d1f) to head (7f80274).
⚠️ Report is 32 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4197      +/-   ##
==========================================
- Coverage   34.24%   32.99%   -1.25%     
==========================================
  Files         461      461              
  Lines       55907    55912       +5     
==========================================
- Hits        19143    18446     -697     
- Misses      33283    34250     +967     
+ Partials     3481     3216     -265     

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2026

❌ 7 Tests Failed:

Tests completed Failed Passed Skipped
4450 7 4443 0
View the top 3 failed tests by shortest run time
TestRedisProduceComplex/two_producers,_some_consumers_killed,_others_should_take_over_their_work,_some_invalid_entries,_unequal_number_of_requests_from_producers
Stack Traces | 2.110s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[01-08|10:31:09.727] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=0 �[36mchecked�[0m=0
�[36mDEBUG�[0m[01-08|10:31:09.730] redis producer: check responses starting
�[36mDEBUG�[0m[01-08|10:31:09.731] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[01-08|10:31:09.732] redis producer: check responses starting
�[36mDEBUG�[0m[01-08|10:31:09.732] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=0 �[36mchecked�[0m=0
�[36mDEBUG�[0m[01-08|10:31:09.737] redis producer: check responses starting
�[36mDEBUG�[0m[01-08|10:31:09.737] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=0 �[36mchecked�[0m=0
�[36mDEBUG�[0m[01-08|10:31:09.737] redis producer: check responses starting
�[36mDEBUG�[0m[01-08|10:31:09.739] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[01-08|10:31:09.742] redis producer: check responses starting
�[36mDEBUG�[0m[01-08|10:31:09.742] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=0 �[36mchecked�[0m=0
�[36mDEBUG�[0m[01-08|10:31:09.745] redis producer: check responses starting
�[36mDEBUG�[0m[01-08|10:31:09.746] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=0 �[36mchecked�[0m=1
�[36mDEBUG�[0m[01-08|10:31:09.749] redis producer: check responses starting
�[36mDEBUG�[0m[01-08|10:31:09.749] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=0 �[36mchecked�[0m=0
�[36mDEBUG�[0m[01-08|10:31:09.752] redis producer: check responses starting
�[36mDEBUG�[0m[01-08|10:31:09.754] request timed out waiting for response   �[36mmsgId�[0m=1767868267745-15 �[36mallowedOldestId�[0m=1767868267752-0
�[36mDEBUG�[0m[01-08|10:31:09.754] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=1 �[36mchecked�[0m=1
    pubsub_test.go:383: Unexpected error while awaiting responses, producer: 1, response: 199, err: error getting response, request has been waiting for too long
--- FAIL: TestRedisProduceComplex/two_producers,_some_consumers_killed,_others_should_take_over_their_work,_some_invalid_entries,_unequal_number_of_requests_from_producers (2.11s)
TestVersion30
Stack Traces | 5.760s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[90mTime to activate bad-export: 8.831641ms�[0;0m
    precompile_inclusion_test.go:94: goroutine 610254 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40fff30, 0xc081188a80}, {0x40bd040, 0xc0d01f6bd0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc081188a80, {0x40bd040, 0xc0d01f6bd0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2041 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc081188a80, 0x1e, {0xc0a745fdb0, 0x6, 0x3?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc081188a80?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc081188a80, 0x3d3e800)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
ERROR[01-08|10:43:38.325] Error pushing sync data from consensus to execution err="context canceled"
--- FAIL: TestVersion30 (5.76s)
TestVersion40
Stack Traces | 6.300s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [01-08|10:43:32.561] HTTP server stopped                      endpoint=127.0.0.1:44461
TRACE[01-08|10:43:32.562] P2P networking is spinning down
    precompile_inclusion_test.go:94: goroutine 610255 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40fff30, 0xc081188c40}, {0x40bd040, 0xc12fe245a0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc081188c40, {0x40bd040, 0xc12fe245a0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2041 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc081188c40, 0x28, {0xc0c9c57df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc081188c40?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc081188c40, 0x3d3e808)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (6.30s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Comment thread cmd/nitro/nitro.go Outdated
Comment thread system_tests/recreatestate_rpc_test.go Outdated
@magicxyyz magicxyyz self-requested a review January 6, 2026 20:02
Copy link
Copy Markdown
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magicxyyz magicxyyz assigned joshuacolvin0 and unassigned magicxyyz Jan 15, 2026
@joshuacolvin0 joshuacolvin0 added this pull request to the merge queue Jan 16, 2026
Merged via the queue into master with commit 7db0e5d Jan 16, 2026
26 checks passed
@joshuacolvin0 joshuacolvin0 deleted the default-state-history branch January 16, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants