Increase Stylus smart contract size limit via merge-on-activate by KolbyML · Pull Request #4193 · OffchainLabs/nitro

KolbyML · 2026-01-02T23:15:40Z

https://linear.app/offchain-labs/project/increase-stylus-smart-contract-size-limit-via-merge-on-activate-e809a493a62b/overview

Pulls in OffchainLabs/go-ethereum#605
Pulls in OffchainLabs/nitro-precompile-interfaces#27

github-actions · 2026-01-05T17:15:01Z

❌ 4 Tests Failed:

Tests completed	Failed	Passed	Skipped
3977	4	3973	0

View the top 3 failed tests by shortest run time

TestVersion40

Stack Traces | 6.090s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0a263b180, 0x28, {0xc274c63df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc0a263b180?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc0a263b180, 0x3ccd330)
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.6/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
INFO [01-24|01:03:20.932] Writing cached state to disk             block=1   hash=a4bcf9..2fb1e9 root=d45d64..4e7811
INFO [01-24|01:03:20.933] Persisted trie from memory database      nodes=23   flushnodes=0 size=3.61KiB   flushsize=0.00B time="130.043µs" flushtime=0s gcnodes=0 gcsize=0.00B gctime="1.754µs"  livenodes=0    livesize=0.00B
INFO [01-24|01:03:20.933] Writing cached state to disk             block=1   hash=a4bcf9..2fb1e9 root=d45d64..4e7811
INFO [01-24|01:03:20.933] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time="1.453µs"   flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [01-24|01:03:20.933] Writing snapshot state to disk           root=28fb26..40a768
INFO [01-24|01:03:20.933] Persisted trie from memory database      nodes=0    flushnodes=0 size=0.00B     flushsize=0.00B time=721ns       flushtime=0s gcnodes=0 gcsize=0.00B gctime=0s         livenodes=0    livesize=0.00B
INFO [01-24|01:03:20.933] Blockchain stopped
INFO [01-24|01:03:20.933] Submitted transaction                    hash=0xd6d68f2fd9265b30d1e3d55f89eeedaf98cdc353a0a29b0220ef8fd1a5a61884 from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=3691 recipient=0x0C709F340F0BB2e361229e345B7e26999d0969Ab value=1
INFO [01-24|01:03:20.933] Submitted transaction                    hash=0x7378401d3fac4ba42eee924eb35380d2ebfabc0e68670979a071a212d5090c8f from=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A nonce=781  recipient=0x7E23C8862920797d81916d62c274dd9217113e28 value=1,000,000,000,000
--- FAIL: TestVersion40 (6.09s)

TestMeaninglessBatchReorg

Stack Traces | 20.300s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [01-24|01:03:44.844] Persisting dirty state                   head=115 root=0ac1fb..885624 layers=115
INFO [01-24|01:03:44.853] Submitted contract creation              hash=0xb6f4ddef9e13f2b49d18fd63e41873d84f04f6d2cce49de9e9ed17886842d32b from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=1    contract=0x3a0a61C11D96F5B8c1492bEaA5bDAedefFff15E8 value=0
INFO [01-24|01:03:44.857] New Key                                  name=User0             Address=0x36CA982ceF5dF10239E4cD6d6cBe0E7FF5F7FdeC
INFO [01-24|01:03:44.970] InboxTracker                             SequencerBatchCount=0
INFO [01-24|01:03:44.971] New local node record                    seq=1,769,216,624,969 id=521f11c6d5caeb14   ip=127.0.0.1 udp=0 tcp=0
INFO [01-24|01:03:44.971] Started P2P networking                   self=enode://45e5f22f23c988afa60d0da931d107ff6a35395583b0931a7d0b7667f7a1525268e6d16e662657f45a31d5453d782ef50e9b592698eff70c3f7c9dcee8ca28c7@127.0.0.1:0
WARN [01-24|01:03:44.971] ExecuteNextMsg failed to send message to execEngine err="createBlock mutex held"              msgIdxToExecute=164
INFO [01-24|01:03:44.971] Submitted transaction                    hash=0xf431ced9c6ab24f33c769261db2cf8d082a24c93b4aa48ae9f38df48e9697b79 from=0x26E554a8acF9003b83495c7f45F06edCB803d4e3 nonce=2    recipient=0x36CA982ceF5dF10239E4cD6d6cBe0E7FF5F7FdeC value=10,000,000,000,000,000
INFO [01-24|01:03:44.973] New Key                                  name=User1             Address=0xdc5a8FD9BFB23295860c7ED77Aa255f3Eaab93e0
WARN [01-24|01:03:44.973] empty sequencer message
WARN [01-24|01:03:44.973] reading virtual delayed message segment  delayedMessagesRead=0 afterDelayedMessages=1
INFO [01-24|01:03:44.973] InboxTracker                             sequencerBatchCount=1   messageCount=1    l1Block=29   l1Timestamp=2026-01-24T01:03:53+0000
INFO [01-24|01:03:44.974] Persisted dirty state to disk            size=481.18KiB elapsed=129.299ms
INFO [01-24|01:03:44.974] Blockchain stopped
INFO [01-24|01:03:44.975] New Key                                  name=Faucet            Address=0xaF24Ca6c2831f4d4F629418b50C227DF0885613A
INFO [01-24|01:03:44.975] New Key                                  name=RollupOwner       Address=0x57Ff0F473737a1c161bfF9efDF016F7991585088
INFO [01-24|01:03:44.975] New Key                                  name=Sequencer         Address=0xb386a74Dcab67b66F8AC07B4f08365d37495Dd23
INFO [01-24|01:03:44.975] New Key                                  name=Validator         Address=0x83FFCFaCE2Fb0E1286686815503608A16EF41e47
INFO [01-24|01:03:44.975] New Key                                  name=User              Address=0x7E23C8862920797d81916d62c274dd9217113e28
--- FAIL: TestMeaninglessBatchReorg (20.30s)

TestTimeboostTxsTimeoutByBlock

Stack Traces | 36.100s run time

... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[01-24|01:03:05.266] Journaled pathdb diff layer              root=09751c..780bdc parent=afaba3..d98512 id=48                                      block=47
DEBUG[01-24|01:03:05.266] Journaled pathdb diff layer              root=69bd35..367948 parent=09751c..780bdc id=49                                      block=48
DEBUG[01-24|01:03:05.266] Journaled pathdb diff layer              root=8610cd..2cedde parent=69bd35..367948 id=50                                      block=49
DEBUG[01-24|01:03:05.266] Journaled pathdb diff layer              root=43550a..b34881 parent=8610cd..2cedde id=51                                      block=50
DEBUG[01-24|01:03:05.266] Journaled pathdb diff layer              root=f8bee9..4deeb5 parent=43550a..b34881 id=52                                      block=51
DEBUG[01-24|01:03:05.266] Journaled pathdb diff layer              root=c94e52..9bd3c7 parent=f8bee9..4deeb5 id=53                                      block=52
DEBUG[01-24|01:03:05.266] Journaled pathdb diff layer              root=61f69f..b4e620 parent=c94e52..9bd3c7 id=54                                      block=53
DEBUG[01-24|01:03:05.266] Journaled pathdb diff layer              root=1b61fb..88b70d parent=61f69f..b4e620 id=55                                      block=54
DEBUG[01-24|01:03:05.266] Journaled pathdb diff layer              root=c18721..be9ee0 parent=1b61fb..88b70d id=56                                      block=55
DEBUG[01-24|01:03:05.267] Journaled pathdb diff layer              root=357a3a..ca5682 parent=c18721..be9ee0 id=57                                      block=56
DEBUG[01-24|01:03:05.267] Journaled pathdb diff layer              root=fb66e7..7aecb8 parent=357a3a..ca5682 id=58                                      block=57
DEBUG[01-24|01:03:05.267] Journaled pathdb diff layer              root=39e9a5..bbe679 parent=fb66e7..7aecb8 id=59                                      block=58
DEBUG[01-24|01:03:05.267] Journaled pathdb diff layer              root=039f29..a98153 parent=39e9a5..bbe679 id=60                                      block=59
INFO [01-24|01:03:05.267] Persisted dirty state to disk            size=271.08KiB elapsed=2.455ms
INFO [01-24|01:03:05.267] Blockchain stopped
TRACE[01-24|01:03:05.267] P2P networking is spinning down
ERROR[01-24|01:03:05.267] Context closed, autonomous auctioneer shutting down
ERROR[01-24|01:03:05.267] Context closed, autonomous auctioneer shutting down
INFO [01-24|01:03:05.267] Context done while waiting redis streams to be ready, failed to start
--- FAIL: TestTimeboostTxsTimeoutByBlock (36.10s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

codecov · 2026-01-05T17:30:14Z

Codecov Report

❌ Patch coverage is 26.08696% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.62%. Comparing base (3a25bb0) to head (de08187).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4193      +/-   ##
==========================================
- Coverage   32.94%   32.62%   -0.32%     
==========================================
  Files         471      471              
  Lines       56610    56670      +60     
==========================================
- Hits        18648    18487     -161     
- Misses      34713    34948     +235     
+ Partials     3249     3235      -14

KolbyML · 2026-01-09T23:57:42Z

@pmikolajczyk41 ready for another look 🫡

tsahee

generally looking good and very close. Tiny comment, since you also need to solve a merge conflict

…tract-size

KolbyML · 2026-01-23T22:08:51Z

@tsahee ready for another look

…tract-size

tsahee

mostly small comments

tsahee · 2026-01-28T00:04:54Z

 		stylusParams.MaxWasmSize = initialMaxWasmSize
 	}
+	if p.ArbosVersion >= params.ArbosVersion_StylusContractLimit {
+		stylusParams.MaxFragmentCount = arbmath.BytesToUint16(take(2))


let's use uint8 and only take 1.
255 fragments should be enough, and we're very close to the 32byte limit.

Ok here is the PR for that #4285

tsahee · 2026-01-28T00:09:34Z

+	return nil, ProgramNotWasmError()
+}
+
+func handleClassicStylus(data []byte, maxSize uint32) ([]byte, error) {


That's a style question, but I don't like this function name. It's visible/theoretically callable from the entire module and "handle" doesn't mean anything for that context. Suggest something like "getWasmFromClassicStylus" or something similar.

tsahee · 2026-01-28T00:17:50Z

+	return arbcompress.DecompressWithDictionary(wasm, int(maxSize), dict)
+}
+
+func handleRootStylus(statedb vm.StateDB, data []byte, maxSize uint32, maxFragments uint16, isActivation bool) ([]byte, error) {


KolbyML force-pushed the increase-stylus-contract-size branch from 53db006 to e4b1efe Compare January 2, 2026 23:18

This was referenced Jan 5, 2026

core, params: Increase Stylus smart contract size limit via merge-on-activate OffchainLabs/go-ethereum#605

Merged

Increase Stylus smart contract size limit via merge-on-activate OffchainLabs/nitro-precompile-interfaces#27

Merged

KolbyML force-pushed the increase-stylus-contract-size branch from e12128c to 4446026 Compare January 5, 2026 16:59

KolbyML mentioned this pull request Jan 5, 2026

Increase Stylus smart contract size limit via merge-on-activate OffchainLabs/nitro-contracts#404

Closed

KolbyML force-pushed the increase-stylus-contract-size branch from 4446026 to 1f80b39 Compare January 5, 2026 17:14

KolbyML force-pushed the increase-stylus-contract-size branch from 1f80b39 to 9c6a7fc Compare January 5, 2026 17:16

KolbyML force-pushed the increase-stylus-contract-size branch 7 times, most recently from 607f160 to 7c85084 Compare January 5, 2026 19:02

KolbyML marked this pull request as ready for review January 5, 2026 20:31

KolbyML requested review from ganeshvanahalli, pmikolajczyk41 and rory-ocl January 5, 2026 20:33

KolbyML assigned pmikolajczyk41 Jan 5, 2026

pmikolajczyk41 reviewed Jan 7, 2026

View reviewed changes

pmikolajczyk41 assigned KolbyML and unassigned pmikolajczyk41 Jan 7, 2026

KolbyML force-pushed the increase-stylus-contract-size branch 2 times, most recently from 6658c10 to 8bbc36d Compare January 9, 2026 20:37

KolbyML requested a review from pmikolajczyk41 January 9, 2026 23:10

KolbyML assigned pmikolajczyk41 and unassigned KolbyML Jan 9, 2026

pmikolajczyk41 removed their assignment Jan 12, 2026

Implement Stylus Contract limit increase

a1c8594

KolbyML force-pushed the increase-stylus-contract-size branch from 8bbc36d to a1c8594 Compare January 12, 2026 17:12

KolbyML requested a review from tsahee January 12, 2026 17:13

KolbyML assigned tsahee and unassigned KolbyML Jan 12, 2026

tsahee added the after-next-version This PR shouldn't be merged until after the next version is released label Jan 13, 2026

Merge branch 'master' into increase-stylus-contract-size

bc11859

KolbyML dismissed pmikolajczyk41’s stale review via bc11859 January 22, 2026 18:00

KolbyML added 3 commits January 22, 2026 12:13

Resolve compiler errors and submodules

6b48d04

Changes from go-ethereum pr review

15bbdc9

merge commit

e371f38

tsahee requested changes Jan 23, 2026

View reviewed changes

Comment thread arbos/programs/programs.go Outdated

KolbyML added 2 commits January 23, 2026 15:07

Fix concern

fdb0be2

Merge remote-tracking branch 'origin/master' into increase-stylus-con…

b4a6488

…tract-size

KolbyML requested a review from tsahee January 23, 2026 22:08

KolbyML added 3 commits January 23, 2026 17:22

Bump go-ethereum pin

60f4479

Merge remote-tracking branch 'origin/master' into increase-stylus-con…

4e989f2

…tract-size

fix TestFragmentedContractFailsOnArbOS50

de08187

tsahee approved these changes Jan 28, 2026

View reviewed changes

tsahee added design-approved and removed after-next-version This PR shouldn't be merged until after the next version is released labels Jan 28, 2026

tsahee enabled auto-merge January 28, 2026 00:56

tsahee added this pull request to the merge queue Jan 28, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jan 28, 2026

KolbyML added this pull request to the merge queue Jan 28, 2026

Merged via the queue into master with commit 670d1bf Jan 28, 2026
28 checks passed

KolbyML deleted the increase-stylus-contract-size branch January 28, 2026 03:24

Conversation

KolbyML commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 4 Tests Failed:

Uh oh!

codecov Bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KolbyML commented Jan 9, 2026

Uh oh!

tsahee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

KolbyML commented Jan 23, 2026

Uh oh!

tsahee left a comment

Choose a reason for hiding this comment

Uh oh!

tsahee Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

KolbyML Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

tsahee Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

tsahee Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KolbyML commented Jan 2, 2026 •

edited

Loading

github-actions Bot commented Jan 5, 2026 •

edited

Loading

codecov Bot commented Jan 5, 2026 •

edited

Loading