Suppress the error sound effect during key repeats#53
Open
BenHetherington wants to merge 4 commits intoOffBroadway:custom-loader-menufrom
Open
Suppress the error sound effect during key repeats#53BenHetherington wants to merge 4 commits intoOffBroadway:custom-loader-menufrom
BenHetherington wants to merge 4 commits intoOffBroadway:custom-loader-menufrom
Conversation
The stock memory card menu only plays the error sound effect when a new input is made, not repeatedly while a button is just held down. This updates the game selection menu code to match this behaviour.
Very minor detail, but in the memory card menu, if you make a diagonal movement, the sound effect that will play will correspond to the horizontal movement (so a failed up and successful right will play ‘move’, and a successful up and a failed right will play ‘error’). This replicates this detail by processing vertical input first, followed by horizontal movement.
trevor403
reviewed
Jun 1, 2025
patches/linker/link_ntsc11.ld
Outdated
| ntsc11_EXIImm = 0x8135a774; | ||
| ntsc11_EXIImmEx = 0x8135a9d0; | ||
|
|
||
| ntsc11_is_key_repeat = 0x81481460; |
Member
There was a problem hiding this comment.
It looks like other functions are calling a get wrapper for this global ala NTSC11 0x81302de0
But I think looking at the variable directly is fine
Author
There was a problem hiding this comment.
Oh whoops, you're right, not sure how I missed that 🤦 Either approach is fine by me, though using the function would make it impossible to accidentally modify it. If we're not worried though I'll leave it as-is 🙂
Author
There was a problem hiding this comment.
I ended up just going ahead and updating this to use the getter, seeing as I was updating other outstanding reviews anyway!
May as well do this the same way as the original code did. As a nice plus, this means we can’t accidentally set this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stock memory card menu only plays the error sound effect when a new input is made, not repeatedly while a button is just held down. This updates the game selection menu code to match this behaviour.
Additionally, this replicates another detail from the memory card menu: if you make a diagonal movement, the sound effect that will play will correspond to the horizontal movement (so a failed up and successful right will play ‘move’, and a successful up and a failed right will play ‘error’).
I've only been able to test this on PAL 1.0, so please do test on other versions before merging!