Add option to show a grid of banners#49
Merged
trevor403 merged 11 commits intoOffBroadway:custom-loader-menufrom Mar 22, 2026
Merged
Add option to show a grid of banners#49trevor403 merged 11 commits intoOffBroadway:custom-loader-menufrom
trevor403 merged 11 commits intoOffBroadway:custom-loader-menufrom
Conversation
This replaces the magic number of ‘8’ icons per row with a variable, allowing it to be modifiable.
This allows it to either be set to `square_icons` for the existing 8x4 grid of square icons, or `banners` for the new 3x4 grid of banners (which have an aspect ratio of 3:1). If not specified, it’ll default to the square icons (the current behaviour).
This adds support for showing a 3x4 grid of banners (at 3:1 aspect ratio), when this grid type is set in the .ini file. To show them at this aspect ratio, it just scales the cubes used for the icons by 3 on the x axis.
This replaces `ASSETS_PER_LINE` with the `columns_per_line` variable, and adds new variables to replace `ASSETS_PER_PAGE` and `ASSETS_INITIAL_COUNT`.
Author
|
While tinkering with this, I had another idea for how this could be laid out – by scaling the banners by 0.75x, it's possible to fit a 4x4 grid on-screen (leaving more vertical space between rows), which might be preferable for those with a lot of games. I'll add this as an extra commit, which can be used by setting |
While tinkering with grids of banners, I had another idea for how to lay it out. By shrinking the grid elements by 0.75x, it’s possible to fit an additional banner per row (leaving more vertical space between rows). This might be preferable for those with larger libraries. This option can be used by setting the `menu_grid_type` .ini setting to `small_banners`.
# Conflicts: # cubeboot/source/main.c # patches/source/grid.c
# Conflicts: # cubeboot/source/main.c
Using a shared header just for settings `enum`s seems nicer than including all of `settings.h` from `patches`.
As these cubes have some padding between the plane used for the icon and the edge of the cube, and rounded corners, scaling one axis of the entire cube model by 3 will also stretch both of these. This resolves this by instead extruding the vertices of the save cube models, such that the plane used for the icons is 3x its original width. The menu will then switch between original and extruded vertex buffers as needed.
As the banner-width icons obviously have a larger width than the original square icons, the same rotation amounts cause their corners to cover a larger area vertically than was originally the case. To keep the icons within the grid a bit better (and to make the rotation a bit less distracting), let’s scale down the y-axis rotation by 3 while banner-width icons are in use.
Author
|
I've just pushed up some extra changes that extrudes the cube model's vertices, rather than scaling the model by 3. This should make it look a fair bit nicer, as it keeps the padding between the icon and outer edges, and the rounded corners, intact. I've tested it on all IPL versions and it seems to work nicely! |
Member
|
I'll work on resolving the conflict and merge soon |
# Conflicts: # patches/source/menu.c
Author
|
Ah yeah, that is the fun of having lots of branches on the go at once 😄 I've now sorted out the conflict here, and I'll try and keep these PRs up-to-date as and when I can! |
trevor403
reviewed
Mar 22, 2026
| #pragma once | ||
|
|
||
| typedef enum { | ||
| MENU_GRID_SQUARE_ICONS, |
Member
There was a problem hiding this comment.
lets equate these so they are always the same value
nevermind!
trevor403
reviewed
Mar 22, 2026
| #include "attr.h" | ||
| #include "os.h" | ||
|
|
||
| typedef struct vtx1_header_t { |
trevor403
reviewed
Mar 22, 2026
|
|
||
| void use_extruded_save_cubes(model_data *textured_model_data, model_data *untextured_model_data) { | ||
| textured_model_data->vertices = &extruded_textured_save_cube_vertices.header; | ||
| untextured_model_data->vertices = &extruded_untextured_save_cube_vertices.header; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option to show a 3x4 grid of 3:1 banners in the game selection menu, allowing game banners to be displayed without needing them to be stretched.
This can be configured using a
menu_grid_layout.ini setting; set this tosquare_iconsfor the existing layout, and tobannersfor this new layout. The default issquare_icons(the status quo).