Skip to content

Conversation

@dbswebsite
Copy link

Also, adding a constant for programatically disabling Better-WP-Minify, BWP_DISABLED.

@JibsouX
Copy link

JibsouX commented Nov 28, 2013

there is a version that work for defered script use lab.js (LAB.min.js) on cdn to deferring the minified string :

  • add a setting to 'do not deferred' one or more script.
  • checkbox to activate or desactivate de theferring function

class-bwp-minify.php :
http://pastebin.com/vWVDr5ug

the project : https://github.com/sireneweb/bwp-minify

@dbswebsite
Copy link
Author

Thanks. Yes, the code looks much more featureful. What I have is very
simple: all is deferred or not deferred. Relatively little additional code.
Individual scripts that are problematic are handled by making them as
general BWP exceptions.

I saw your project, and was concerned about "LOT OF WORK TO DO FOR THE
STABLE VERSION " type comments, but in long run may have greater overall
benefits.

Mine is tested on 2 very complex WP projects. The only problem I have (so
far) is jQuery core is a problem when deferred, due to code running early
in DOM. I have previously had filters in functions.php to add 'defer' to
all scripts (except jQuery). That approach is tested on 6-8 projects and
relatively safe. This is why I thought the "all or none" approach was maybe
not ideal, but satisfactory.

On Thu, Nov 28, 2013 at 8:38 AM, JibsouX notifications@github.com wrote:

there is a version that work for defered script use lab.js (LAB.min.js) on
cdn to deferring the minified string :

  • add a setting to 'do not deferred' one or more script.
  • checkbox to activate or desactivate de theferring function

http://pastebin.com/vWVDr5ug


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-29463999
.

Hal Burgiss
Project Management
Chief Technology Officer
DBS_>Interactive_

@JibsouX
Copy link

JibsouX commented Nov 28, 2013

BY LOT OF WORK TO DO FOR THE STABLE VERSION i mean that the plugin is under beta testing : beta 3 i test it on many wp and 2 also complexe and it work well no conflic (and if there is some simply put the handle of the script that create the conflict in to minify solo or to not deferring ;)

and the deferring capabilitie make the all string of the minification asyncro : script1.js,script2.js, ... not 1 by one thanks to the Lab library :)

like here : http://preuves-par-images.fr/

@OddOneOut
Copy link
Owner

Hi JibsouX, are you still working on this feature? I'm still considering whether to add this to 1.3.0 or not, but since you have named your version 1.3.6 perhaps I should wait for 1.3.6? haha.

@dbswebsite
Copy link
Author

Just curious if CDN support is ready or still in the roadmap? I have a
simple version with checkbox to defer all js, which I've used fine on
several production sites.

On Fri, Feb 21, 2014 at 2:09 PM, K.Minh notifications@github.com wrote:

Hi JibsouX, are you still working on this feature? I'm still considering
whether to add this to 1.3.0 or not, but since you have named your version
1.3.6 perhaps I should wait for 1.3.6? haha.


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-35762422
.

Hal Burgiss
CTO and DevOps
DBS_>Interactive_ http://www.dbswebsite.com/

@OddOneOut
Copy link
Owner

Not yet ready, but will be included in 1.3.0 as well, I will push the 1.3.0 branch on Github so people can play with it and help me beta test as well :-).

That simple version is available somewhere?

@dbswebsite
Copy link
Author

Sorry its a fork: https://github.com/dbswebsite/Better-WordPress-Minify. A
few other small things for how I/we use bwp.

I would indeed be interested in testing cdn code. Thx.

On Sat, Feb 22, 2014 at 1:18 AM, K.Minh notifications@github.com wrote:

Not yet ready, but will be included in 1.3.0 as well, I will push the
1.3.0 branch on Github so people can play with it and help me beta test as
well :-).

That simple version is available somewhere?


Reply to this email directly or view it on GitHubhttps://github.com//pull/3#issuecomment-35796003
.

Hal Burgiss
CTO and DevOps
DBS_>Interactive_ http://www.dbswebsite.com/

@solhuebner
Copy link

"Not yet ready, but will be included in 1.3.0 as well"... so is this PR obsolete now?!

@OddOneOut
Copy link
Owner

Unfortunately yes, I will work on another PR, but this is kept open to remind me about this to-do :-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants