fix: remove unstable selector labels in mssql and octopus statefulsets#540
fix: remove unstable selector labels in mssql and octopus statefulsets#540liam-mackie wants to merge 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: e0eb40e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ix-sts-dynamic-selectors
| {{- end }} | ||
| containers: | ||
| - name: pre-upgrade | ||
| image: bitnami/kubectl:latest |
There was a problem hiding this comment.
Wouldnt it be safer to use a specific tag rather than :latest?
There was a problem hiding this comment.
looks like latest still better.
bitnami uses sha for tag names, which not readable and also the oldest image in registry 2 was created months ago. Maybe they have some retention.
| "helm.sh/hook": pre-upgrade | ||
| "helm.sh/hook-weight": "-5" | ||
| "helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded | ||
| rules: |
There was a problem hiding this comment.
I would add a way to disable this hook (and the extra role/rolebinding/service account) since once the user upgrades and all the stateful sets are recreated with the correct labels, there is no longer need to run the hook.
There was a problem hiding this comment.
what default behaviour u suggest?
-
enabled: false- that makes things inconvenient, as requires user to read docs once meet issue and we don't know from which version to which they gonna update. -
enabled: true- I guess in most cases users also won't bother about having this extra value
3 participants
No description provided.