Conversation
acodrington
approved these changes
Feb 24, 2026
Contributor
acodrington
left a comment
acodrington
left a comment
There was a problem hiding this comment.
Looks good, thanks. I've just got a question that I'd like to have answered for future reference.
| var combinedFileName = $"tentacle.{OctoVersionInfo.FullSemVer}-sbom.cdx.json"; | ||
|
|
||
| // redirect all docker output to stdout, as lots of it goes as stderr when it's just progress messages | ||
| DockerTasks.DockerLogger = (_, message) => Log.Information("[Docker] {Message}", message); |
Contributor
There was a problem hiding this comment.
Why is this no longer necessary? Is it now handled in Nuke 9?
acodrington
reviewed
Feb 24, 2026
| { | ||
| // Docker typically logs everything to stderr so we're | ||
| // redirecting it to Debug to make the logs look a bit nicer. | ||
| DockerTasks.DockerLogger = (outputType, message) => |
Contributor
There was a problem hiding this comment.
Why is this no longer necessary? Is it now handled in Nuke 9?
Contributor
Author
There was a problem hiding this comment.
Yeah, it's built in now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
We like to stay on top of our dependency updates
Results
Thus PR upgrade nuke to 9.0.4, the newest that supports net8.0.
How to review this PR
Quality ✔️
Pre-requisites