Skip to content

Fix flaky test: k8s script v1 integration test #1189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
todthomson merged 3 commits into from
Feb 23, 2026
Merged

Fix flaky test: k8s script v1 integration test #1189

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcb8829
fix: StartScriptAsync.Started.Should().BeGreaterThanOrEqualTo(1)...
todthomson Feb 23, 2026
02921bb
misc: comments only
todthomson Feb 23, 2026
60723d2
misc: fix comment from PR review only
todthomson Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ....Kubernetes.Tests.Integration/KubernetesAgent/KubernetesScriptServiceV1IntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,10 @@ public async Task RunSimpleScript(ScriptType scriptType)
result.ExitCode.Should().Be(0);
result.State.Should().Be(ProcessState.Complete);

recordedMethodUsages.For(nameof(IAsyncClientKubernetesScriptServiceV1.StartScriptAsync)).Started.Should().Be(1);
// We occasionally see that communication with Tentacle gets interrupted, causing Tentacle to reconnect and restart the script.
// This could therefore happen more than once, which this assertion supports.
recordedMethodUsages.For(nameof(IAsyncClientKubernetesScriptServiceV1.StartScriptAsync)).Started.Should().BeGreaterThanOrEqualTo(1);

recordedMethodUsages.For(nameof(IAsyncClientKubernetesScriptServiceV1.GetStatusAsync)).Started.Should().BeGreaterThan(1);
recordedMethodUsages.For(nameof(IAsyncClientKubernetesScriptServiceV1.CompleteScriptAsync)).Started.Should().Be(1);
recordedMethodUsages.For(nameof(IAsyncClientKubernetesScriptServiceV1.CancelScriptAsync)).Started.Should().Be(0);
Expand Down