Skip to content

Comments

Create a single method that supplies the min set of env vars Tentacle passes to scripts, to simplify In Processes Tentacle And Tentacle Simulator.#1188

Merged
LukeButters merged 1 commit intomainfrom
luke/move-env-vars-to-method
Feb 17, 2026
Merged

Create a single method that supplies the min set of env vars Tentacle passes to scripts, to simplify In Processes Tentacle And Tentacle Simulator.#1188
LukeButters merged 1 commit intomainfrom
luke/move-env-vars-to-method

Conversation

@LukeButters
Copy link
Contributor

@LukeButters LukeButters commented Feb 17, 2026

Background

One of the pains in creating an in process tentacle is setting the environment variables that are passed to scripts.

With this change we now have a method to call which will set all of those environment variables for us. This method takes care of deriving variables which means we don't need to do that work in out tests or in tentacle simulator.

How to review this PR

This PR should make no change to how Tentacle currently works.

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

…ronment variables passed to tentacle scripts
@LukeButters LukeButters requested a review from a team as a code owner February 17, 2026 00:37
/// Gets most environment variables for scripts.
/// This will be enough for running a Tentacle in testing.
/// </summary>
public static List<TentacleEnvironmentVariable> EnvironmentVariablesForScripts(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could call this in tests or tentacle simulator to get the env vars rather than us need to work them out.

@LukeButters LukeButters changed the title Simplify in process Tentacles, by creating a single method that supplies the min set of env vars Tentacle passes to scripts. Creating a single method that supplies the min set of env vars Tentacle passes to scripts, to simplify In Processes Tentacle And Tentacle Simulator. Feb 17, 2026
@LukeButters LukeButters changed the title Creating a single method that supplies the min set of env vars Tentacle passes to scripts, to simplify In Processes Tentacle And Tentacle Simulator. Create a single method that supplies the min set of env vars Tentacle passes to scripts, to simplify In Processes Tentacle And Tentacle Simulator. Feb 17, 2026
Copy link
Contributor

@david-staniec-octopus david-staniec-octopus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukeButters LukeButters enabled auto-merge (squash) February 17, 2026 02:25
@LukeButters LukeButters merged commit 99a3867 into main Feb 17, 2026
51 checks passed
@LukeButters LukeButters deleted the luke/move-env-vars-to-method branch February 17, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants