-
Notifications
You must be signed in to change notification settings - Fork 503
Added step to check for targets with the supplied tags #1628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Start Hyponome locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new step template that allows deployment processes to check for the presence of targets with specified tags in an Octopus space, failing the deployment with a custom message if no matching targets are found.
- Introduces a PowerShell-based step template for target validation
- Validates target availability before deployment execution
- Provides configurable error messaging for failed validations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
step-templates/octopus-check-roles.json:1
- The API endpoint uses 'roles=$role' parameter but the template description and labels refer to 'tags'. In Octopus Deploy, roles and tags are different concepts. If checking for tags, the API parameter should be 'machineNames' or similar tag-based filtering.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
robpearson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simple script. 👌
Step template guidelines
.jsonfilename consistent with the name of the template?Before submitting your PR, please delete everything above the line below.
Background
This step allows a deployment process to check that targets with the defined tag are present in the Octopus space.
Pre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to itFixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line