-
Notifications
You must be signed in to change notification settings - Fork 503
Added a step to check the SMTP server is configured #1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Start Hyponome locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new step template that validates whether an SMTP server has been configured in Octopus Deploy. The template provides a PowerShell script that checks the SMTP configuration status via the Octopus API and outputs appropriate messages based on the result.
- Introduces a new step template for checking SMTP server configuration
- Uses the Octopus API to validate SMTP settings
- Provides clear feedback when SMTP is not configured with documentation links
Comments suppressed due to low confidence (1)
step-templates/octopus-smtp-server-configured.json:1
- The error message references 'Project.Octopus.Api.Key' but the actual parameter name is 'SmptCheck.Octopus.Api.Key' (which should be 'SmtpCheck.Octopus.Api.Key'). Update the message to reference the correct parameter name.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
step-templates/octopus-smtp-server-configured.json:1
- The PowerShell script body should be properly formatted with line breaks and indentation for better readability. Currently, it's stored as a single escaped string which makes it difficult to maintain.
{
step-templates/octopus-smtp-server-configured.json:1
- The API key validation assumes all valid keys start with 'API-'. This hardcoded prefix could become outdated if Octopus changes their API key format. Consider using a more flexible validation approach or documenting this assumption.
{
step-templates/octopus-smtp-server-configured.json:1
- The error message contains Markdown formatting that may not render properly in the Octopus Deploy console output. Consider using plain text or HTML formatting instead.
{
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
robpearson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good. Simple script!
Step template guidelines
.jsonfilename consistent with the name of the template?Before submitting your PR, please delete everything above the line below.
Background
This step provides a script to confirm that the SMTP server has been configured in Octopus.
Results
A new step is provided to confirm the SMTP server is configured.
Pre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to itFixes # . If there is an open issue that this PR fixes add it here, otherwise just remove this line