Helm Updater was writing bad text into the PR field.#1804
Merged
Conversation
Contributor
rain-on
commented
Feb 25, 2026
rain-on
commented
rain-on
force-pushed
the
tmm/fix_pr_text
branch
from
ce52dcf to
671240e
Compare
flin-8
reviewed
Feb 25, 2026
| } | ||
|
|
||
| updatedImages.Add(matchedUpdate.ToString()); | ||
| updatedImages.Add(matchedUpdate.Reference.ToString()); |
Contributor
There was a problem hiding this comment.
Don't use .ToString(), create a different method name
Contributor
Author
There was a problem hiding this comment.
worried that changing that will have knock on effects where people maybe leaning into the implicit cast :/
Might be no where ... but searching for it doesn't work so well!
flin-8
reviewed
Feb 25, 2026
| } | ||
|
|
||
| public override string ToString() | ||
| public string FriendlyName() |
Contributor
There was a problem hiding this comment.
Then maybe this should be called QualifiedName?
Contributor
Author
There was a problem hiding this comment.
man - make up your mind! :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.