Remove trimming of trailing slash to ensure adding v2 does not remove the subpath#1799
Open
chrischu wants to merge 1 commit intoOctopusDeploy:mainfrom
Open
Remove trimming of trailing slash to ensure adding v2 does not remove the subpath#1799chrischu wants to merge 1 commit intoOctopusDeploy:mainfrom
chrischu wants to merge 1 commit intoOctopusDeploy:mainfrom
Conversation
…ot override the subpath
Author
|
Unfortunately there does not seem to be tests for the OciPackageDownloader, therefore I could not adjust tests :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #9895.
When calling
new Uri(new Uri("https://domain/sub"), "v2")returnshttps://domain/v2, whilenew Uri(new Uri("https://domain/sub/"), "v2")returnshttps://domain/sub/v2