Skip to content

Feat/ddo v5#58

Closed
dasimonde wants to merge 71 commits intomainfrom
feat/ddoV5
Closed

Feat/ddo v5#58
dasimonde wants to merge 71 commits intomainfrom
feat/ddoV5

Conversation

@dasimonde
Copy link
Copy Markdown

This PR adds support for the new DDO v5 format to the market

Comment thread scripts/barge-env.sh
@@ -1,2 +1,2 @@
# Set
node ./scripts/load-development-addresses.js No newline at end of file
node ./scripts/load-development-addresses.cjs No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eof

if (accountId !== ZERO_ADDRESS) {
toast.error(
`Consumer address not found in allow list for service ${asset.id}. Access has been denied.`
`Consumer address not found in allow list for service ${asset.credentialSubject?.id}. Access has been denied.`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here... id is in asset

<div>
<AssetTitle title={metadata.name} asset={row} />
<p>{row.id}</p>
<p>{row.credentialSubject?.id}</p>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same.. id is in asset.id so row.id

<AssetTeaser
asset={asset}
key={asset.id}
key={asset.credentialSubject?.id}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same. is good asset.id

async function getDatasetsAllowedForCompute() {
const datasets = await getAlgorithmDatasetsForCompute(
asset.id,
asset.credentialSubject?.id,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asset.id is correct

const credential: VCDataModel.Credential = {
...asset,
type: ['VerifiableCredential'],
issuer: `${await owner.getAddress()}`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issuer is not everytime the address of web3account.. if ssi is on the issuer id issuerDid, check in cli

@AdriGeorge
Copy link
Copy Markdown

@FilipMasar can you please have a look into this pr?

@dasimonde
Copy link
Copy Markdown
Author

This branch is depreacted. Every changes will be doing in the feat/ssiSupport branch.

@dasimonde dasimonde closed this Feb 14, 2025
@dasimonde dasimonde deleted the feat/ddoV5 branch February 14, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants