Conversation
|
Hmm, this might be not true at all or just for Linux. I'll need to look at it a bit more.
|
Decode them when function is called Allows to avoid issues caused by MATLAB using different encodings
e292be2 to
f597cac
Compare
|
Instead of saving an m-file with an older encoding, replaced special characters with corresponding UTF-8 bytes sequences. When function is executed, bytes are decoded with explicitly specified encoding by MATLAB. It helps to mitigate different default encodings used by different versions of MATLAB. |
There was a problem hiding this comment.
Nice, thanks for adding the version info.
I took a look and the file exchange compatibility seems to be set when packaging a toolbox. The packaged toolbox is here: https://github.com/OceanNetworksCanada/api-matlab-client/tree/main/dist it looks like it is a couple of versions out of date.
In a separate issue can you create a new version of the toolbox package with correct version compatibility, (probably use the version of the next release in the toolbox name). Then work with @spencerwplovie to do a new release? The toolbox may need to be attached to the release itself. See "GitHub Releases" in: https://www.mathworks.com/matlabcentral/content/fx/about.html
This PR solves #37.
There is an issue with handling special characters in MATLAB versions supposedly R2019a and older. As I understood according to a comment on mathworks, MATLAB changed default encoding from windows-1252 to UTF-8 in R2019b. Newer versions of MATLAB seem to handle older encoding, but not the other way around. So, I replaced a special character in progress bar class with an ASCII symbol which is similar in both encodings. But similar solution was not possible for
util.extract_tree(). That is why this function is resaved with an older encoding.Besides the commits, version requirements have been updated on wiki page.
I'm not sure that I have permissions to update information on File Exchange. It would be great to fix it as well.