PATCH: Prevent false reader_stalled aborts on idle upstreams#25
Merged
rocketpages merged 2 commits intomainfrom Mar 26, 2026
Merged
PATCH: Prevent false reader_stalled aborts on idle upstreams#25rocketpages merged 2 commits intomainfrom
rocketpages merged 2 commits intomainfrom
Conversation
Signed-off-by: Kevin Webber <kevin@obzenflow.dev>
Signed-off-by: Kevin Webber <kevin@obzenflow.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
CONTRIBUTING.mdgit commit -scargo fmt --allcargo test --workspaceSummary
Fix a regression in stall detection where live subscriptions started the stall timer before reading any data. This keeps idle flows from aborting with
reader_stalledwhile waiting for their first event, and adds a regression test to lock the behaviour down.