fix: allow md5sum check to include /usr/local/bin#400
Closed
sr-murthy wants to merge 1 commit intoOasisLMF:developfrom
sr-murthy:md5sum-fix-for-mac
Closed
fix: allow md5sum check to include /usr/local/bin#400sr-murthy wants to merge 1 commit intoOasisLMF:developfrom sr-murthy:md5sum-fix-for-mac
/usr/local/bin#400sr-murthy wants to merge 1 commit intoOasisLMF:developfrom
sr-murthy:md5sum-fix-for-mac
Conversation
Contributor
Author
|
Attached is a full log of a ktools installation with this change via my |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sambles A small tweak to
configure.acto add/usr/local/bin/md5sumin themd5sumcheck - this check would pass if the user had installed it viaapton Linux orbrewon Macs. For Macs, a Brew install is insufficient as a symlink would still need to be created in/usr/local/bin, but this is common practice.This is the
./configurecheck before the change:checking Check for /usr/bin/md5sum ... no ...This is the same line after the change:
checking Check for /usr/bin/md5sum or /usr/local/bin/md5sum ... yesWhether this makes any difference to the checksums in
make testI'm not sure, but it is a friendlier configuration.