Move from drf-yasg to drf-spectacular #1340
Conversation
There was a problem hiding this comment.
So I've tested it locally.
Logging in on http://ui.oasis.local/ seems to work fine
Logging in via the "Authorize" button on http://ui.oasis.local/api/ doesn't work
- I can enter client_id and client_secret fine
- I get redirected to authentiks login page fine
- I don't get redirected back to the api page, instead getting a 404 not found error for a URL http://ui.oasis.local/api/oauth2-redirect.html?code=\<some long code>
Not sure what the fix exactly would be, whether it's a spectacular config issue or authentik (and maybe keycloak).
P.S. I think by default drf-spectacular uses authorizationCode WITH PKCE, which is why there is that extra "code=" bit at the end of the URL. I don't think this is important for now but it's just worth noting that the OIDC was setup for authorizationCode WITHOUT PKCE, so maybe the spectacular settings should be updated for consistency too.
|
Forgot to mention, but there is an extra cookieAuth section added now on the Authorize button popup. I've ignored this for now, not sure if you want to keep this or not. |
ef86094 to
26989c1
Compare
SkylordA
left a comment
There was a problem hiding this comment.
looks good now, auth working on api and ui pages
Move from drg-yasg to spectacular