Remove redundant code, fix bugs, and improve efficiency#32
Open
benhayes21 wants to merge 1 commit intodevelopfrom
Open
Remove redundant code, fix bugs, and improve efficiency#32benhayes21 wants to merge 1 commit intodevelopfrom
benhayes21 wants to merge 1 commit intodevelopfrom
Conversation
- Deduplicate read_csv/read_parquet in OasisPandasReader via _read_with helper - Consolidate triplicated dataset logic in OasisPyarrowReader.read_parquet - Extract _normalize_root_dir to BaseStorage, replacing duplicated stripping in S3/Azure backends - Extract _safe_check helper in StrictRootDirFs for repeated try/except pattern - Extract _parse_log_level helper in log.py for duplicated log level parsing - Remove unnecessary Python 3.8 version guards in config modules - Remove redundant httpx exception subclasses in RestComplexData - Fix dead ternary branch in ComplexData.run - Fix O(n*m) column mapping in OasisDaskReader.apply_sql with dict-based O(n+m) lookup - Fix unbounded pre_sql_columns growth in apply_sql by using local list - Fix inconsistent logging.info vs self.logger usage in BaseStorage - Use shutil.copyfileobj for streaming URL downloads instead of reading into memory - Fix bug: split_azure_url used parts.get() instead of query.get() - Fix unused import and broken urllib.parse.urlunparse references in filestore.py - Fix shallow inheritance check in load_class using issubclass() - Add CLAUDE.md for Claude Code guidance Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
split_azure_urlusingparts.get()instead ofquery.get(), fixed brokenurllib.parse.urlunparsereferences, and fixed shallow inheritance check inload_classthat only checked direct parents_read_with), pyarrow reader source resolution, root dir normalization (_normalize_root_dir),StrictRootDirFssafe checks, and log level parsingOasisDaskReader.apply_sqlwith O(n+m) dict lookup, fixed unboundedpre_sql_columnsgrowth, switched URL downloads to streaming viashutil.copyfileobjComplexData.run, unnecessary Python 3.8 version guards, unused import, and inconsistentlogging.infovsself.loggerusageNet result: 13 files changed, 159 insertions, 147 deletions.
Test plan
🤖 Generated with Claude Code