fix(httpclient): URL-encode dict data without files#94
Merged
Conversation
_prepare_body(data={"key": "value"}) silently returned (None, None)
when files was not provided. Add a dict branch that URL-encodes the
data as application/x-www-form-urlencoded, matching httpx/requests
behavior.
Closes #93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_prepare_body(data={"key": "value"})silently returned(None, None)whenfileswas not provided — the dict fell through all branchesdictbranch that URL-encodes the data asapplication/x-www-form-urlencoded, matchinghttpx/requestsbehaviorurlencodewas already imported, so no new imports neededCloses #93
Test plan
TestPrepareBody(6 cases: basic dict, special chars, empty dict, json priority, str data, None data)